Export to GitHub

socketio-java - issue #6

Migration to GitHub


Posted on Jan 21, 2011 by Happy Elephant

GitHub is a better place to contribute, pull requests, review and clone projects. Some scripts exists to export a Mercurial repo into a Git repo.

I've exported to my GitHub Socket.IO Java here:

https://github.com/mathieucarbou/Socket.IO-Java

Since we really need to contribute a lot, an access to the code base in github is a requirement for us. So we've migrated the source there.

We will still send you patched as long as we can but since we will shortly convert the project to Maven and split it in several submodules and also migrate to Socket.IO's trunk, it will become more difficult for you to merge. It is possible also that we make a lot of API changes to better support DI frameworks and perhaps also use execution queues to avoid synchronization points in the XHRTransport class. Synchronizing a long block of code calling listeners is really not recommended and may lead to poor performances. There are a lot of good reasons for this described in Effective Java so I won't elaborate here ;-)

I think a good way would be that you move the codebase to your github so that we can work on a fork. Then it would be easier for you to integrate changes. Mercurial has a plugin to work with Git Repos also.

Let me know what you think about all of this !

Thanks,

Mathieu.

Comment #1

Posted on Jan 23, 2011 by Grumpy Rhino

The code has been imported into GitHub (with history) and the last commit converts the line endings to LF.

Please fork that project and create push requests.

Comment #2

Posted on Jan 24, 2011 by Happy Elephant

Comment deleted

Comment #3

Posted on Jan 24, 2011 by Happy Elephant

I've sent you pull requests for the two other issues i've opened

Comment #4

Posted on Mar 9, 2011 by Grumpy Bird

The github link is 404 page not found. And there is no other obvious places this project has moved to.

Comment #5

Posted on Mar 9, 2011 by Grumpy Rhino

The github links are: https://github.com/tadglines/Socket.IO-Java https://github.com/Ovea/Socket.IO-Java

The first is current "official" version on github. The second is Matheu Carbou's fork and also the place where most of the development is currently happening. For now, you'll probably want to use Matheu's version.

Status: Accepted