Export to GitHub

soc - issue #2566

Invalid characters in the name of my Country (Drop Down List)


Posted on Mar 16, 2015 by Helpful Panda

Please note that issues filed that do not follow this template will be marked as Invalid

What steps will reproduce the problem? 1. Go to http://www.google-melange.com/gsoc/homepage/google/gsoc2015 2. Click on "Create Profile" (Student) 3. Fill all the fields 4. Select "Ivory Coast (Cote d'Ivoire)" as "Country/Territory" 5. Submit the form 6. An error message displays : "Invalid characters. Only English letters (a-z or A-Z), numbers (0-9), spaces, and comma (,), period (.), dash (-), and forward slash (/) are allowed."

What is the expected output? What do you see instead?

Expected output : Submit data Instead : Invalid characters. Only English letters (a-z or A-Z), numbers (0-9), spaces, and comma (,), period (.), dash (-), and forward slash (/) are allowed. URL : http://www.google-melange.com/gsoc/profile/register/student/google/gsoc2015#

Date : 16/03/2015 (dd/MM/YYYY) - 19h20

Attachments

Comment #1

Posted on Mar 16, 2015 by Happy Rabbit

Thanks for reporting this. We will get it fixed in the next few days, you will still have plenty of time to apply.

Comment #2

Posted on Mar 16, 2015 by Quick Monkey

How do we want to fix it? Allow extra characters or remove apostrophe from the country name? Or we can remove the second part?

ouattararomuald, we are sorry for the inconvenience. The good thing is that you're probably one of the first who has ever tried to register from Ivory Cost :)

Comment #3

Posted on Mar 16, 2015 by Happy Rabbit

Daniel: We can just compare the list against the COUNTRIES_AND_TERRITORIES list. Lets assume that values in that list are ok. If you want to grab this one, please claim the bug.

Comment #4

Posted on Mar 16, 2015 by Quick Monkey

Oh, sorry. I thought you assigned me but I am only in CC. The reason we check it (which is stupid) was shipping process as you probably know. If possible, yes we should get rid of this extra validation level.

Comment #5

Posted on Mar 16, 2015 by Happy Rabbit

If you have time to grab it, that wouldn't be a bad thing.

I am happy with the check being

if not self.cleaned_data['shipping_country'] in COUNTRIES_AND_TERRITORIES_LIST: raise django_forms.ValidationError("Invalid country.")

Comment #6

Posted on Mar 17, 2015 by Happy Rabbit

Fix out for review.

Comment #7

Posted on Mar 17, 2015 by Happy Rabbit

Issue 2569 has been merged into this issue.

Comment #8

Posted on Mar 17, 2015 by Happy Rabbit

Issue 2571 has been merged into this issue.

Comment #9

Posted on Mar 17, 2015 by Happy Rabbit

(No comment was entered for this change.)

Comment #10

Posted on Mar 17, 2015 by Happy Rabbit

Release rolling out in 20150317

Status: Fixed

Labels:
ReportABug Priority-High Type-Defect Milestone-GSoC Program-GSoC GSOCHotlist Effort-Fair Component-Logic