Export to GitHub

sitemapgen4j - issue #4

Google-News-Sitemap xmltags missing


Posted on Jan 27, 2010 by Happy Bear

Its currently not possible to create a complete google-news-sitemap with this tool. Tags like "title" or "publication" are important and missing.

Comment #1

Posted on Apr 13, 2010 by Grumpy Wombat

I noticed this problem as well when I was looking at the javadoc. This is more than just a bug since you cannot even create a valid news sitemap as the previous poster said. This means the classes related to google news sitemaps are useless as is. Please address this because you cannot say that your tool supports this type of sitemap when it actually does not.

Comment #2

Posted on Apr 14, 2010 by Massive Lion

This does appear to be a real problem. Unfortunately, I don't use News Sitemaps, so I may not be able to fix this in a timely manner. Patches welcome.

Comment #3

Posted on Apr 14, 2010 by Grumpy Wombat

OK I have created a patch to fix this. What is the process to submit the patch?

I have attached a zip file containing the code.

Here is a quick list of the changes:

Added classes: Acess - enum class for valid access values in the google news sitemap Genre - enum class for valid genre values in the google news sitemap

Changes classes: GoogleNewsSitemapUrl - add new fields for new tags, with getter methods and setters in the Options class GoogleNewsSitemapGenerator - changed rendered to render new tags GoogleNewsSitemapUrl - added new test "testFullOptions" to test all new tags

Note: the changes should not affect the behaviour of any existing code that uses these classes in any way

Attachments

Comment #4

Posted on May 9, 2011 by Swift Elephant

Thanks for posting this. I think that these new additions to Google's algorithm will make online the XML sitemap generator tools even more important.

Comment #5

Posted on Nov 8, 2012 by Happy Rabbit

Any chance the patch will be accepted?

Comment #6

Posted on Oct 14, 2014 by Grumpy Camel

I noticed that this issue is still not resolved and the patch has not been accepted. The News Sitemap is unusable without it, any chance this can still be accepted?

Comment #7

Posted on Mar 20, 2015 by Helpful Bird

Could you please open a pull request with the fix at https://github.com/dfabulich/sitemapgen4j ?

Status: Accepted

Labels:
Type-Defect Priority-High