Export to GitHub

simplemodal - issue #5

resize reposition fails when iframe is disabled


Posted on Dec 5, 2008 by Swift Rabbit

What steps will reproduce the problem? 1. set iframe: false 2. resize the screen

What is the expected output? What do you see instead? box should be repositioned, will receive javascript warning noting that self.dialog.iframe is undefined

What version of the product are you using? On what operating system? xp - firefox 3

Please provide any additional information below. added line 293: if (self.dialog.iframe) { self.dialog.iframe.css({height: w[0], width: w[1]}); }

Comment #1

Posted on Dec 5, 2008 by Massive Ox

Thanks for catching this. I added a fix in 1.2.1, making sure that nothing was called on dialog.iframe unless it exists:

For example: self.dialog.iframe && self.dialog.iframe.css({height: w[0], width: w[1]});

Status: Fixed

Labels:
Type-Defect Priority-Medium