This has come up multiple times. The initial reason it doesn't have them was (IIRC) that the HIG only specified it for dialogs and it could close the window when canceling a cellrenderer in the tag editor while changing text.

TODO:

1) Add a dialog for when there are unsaved changes ("Close Window", "Continue Editing") 2) Enable esc accel

It's also bad for people with muscle memory inspired by vi. Is the problem that C-w is too undiscoverable?

(I've opened this in reference to https://groups.google.com/forum/#!topic/quod-libet-development/PEQZq6l02Xc )

My guess is that you can get by using alt+f4 + esc alone in many other applications. So ctrl+w doesn't come to mind.

In which scenario(s) do you think you will hit esc due to vi muscle memory? (no vi user..)

In vi you use Escape to switch from typing to moving, so perhaps after typing in the new value for a tag. (I'm no longer in the habit myself.) The proposed confirmation dialog may address that case, so long as escape cancels the close.

If Alt+F4 doesn't work, that sounds like a bug, but it isn't any nicer to press than Ctrl+F4.

I was guessing that alt-f4 is used for applications windows and esc for dialogs and the tagging/info window appears as a dialog at first sight, leading users to press esc first... but not sure..

Anyway, making sure that any kind of action which might result in data loss is abortable seems like a good thing anyway, so lets do that first and see how it turns out.

Because Google Code is going away [0] we've moved this bug tracker to GitHub.

This issue is now available at

https://github.com/quod-libet/quodlibet/issues/1556

In case you are still interested in this issue and have a GitHub account, you can subscribe to the new issue using the "Subscribe" button on the right hand side of the page.

[0] http://google-opensource.blogspot.co.at/2015/03/farewell-to-google-code.html