Export to GitHub

pybing - issue #3

In BingQuery.get_search_response, the json module is overwritten

Posted on Dec 10, 2009 by Helpful Camel

The function is

def get_search_response(self):
    json = self._get_url_contents(self.get_request_url())
    return json.loads(json)['SearchResponse'][self.SOURCE_TYPE]

but should be something like

def get_search_response(self):
    json_string = self._get_url_contents(self.get_request_url())
    return json.loads(json_string)['SearchResponse'][self.SOURCE_TYPE]

so that the json module doesn't get overwritten.

Comment #1

Posted on Dec 10, 2009 by Massive Bird

(No comment was entered for this change.)

Comment #2

Posted on Dec 10, 2009 by Massive Bird

(No comment was entered for this change.)

Comment #3

Posted on Jan 27, 2011 by Massive Bird

Fixed in r33

Status: Fixed

Labels:
Type-Defect Priority-Medium