Export to GitHub

phpfr - issue #3

External Links in PHP Manual


Posted on Apr 10, 2007 by Massive Ox

What steps will reproduce the problem? 1. Use PHPfr to lookup the "header" function in the PHP manual. 2. Click the first link: "HTTP/1.1 specification".

What is the expected output? What do you see instead? This is an external link in the PHP manual. The expected output is the content of the hypertext reference. Instead, you will see an error message.

In the specific case of the header function, the hypertext reference should be the following location: http://www.faqs.org/rfcs/rfc2616

Currently, PHPfr performs a global search and replace on all links in the pages it displays. Links to external websites will not work.

Options for enhancement (brainstorm):

  1. Refinement

Refining the global search and replace so that external links retain their integrity. External links should probably open in the user's default browser, forcing an exit from the dashboard, so the user ought to be warned. Perhaps a style could be applied to external links to visually denote an external reference. The user could also be prompted with a dialog and given the options to either cancel their click, open the link in the default browser, or open the link in the background.

  1. Disengagement

Disable external links by stripping their anchor tag.

Attachments

Comment #1

Posted on Apr 10, 2007 by Massive Ox

References:

scripts/PHPfr.js:51-57 scripts/PHPfr.js:605

Comment #2

Posted on Mar 27, 2008 by Quick Kangaroo

This now works as of 1.0b.

Status: Fixed

Labels:
Type-Enhancement Priority-Low