Export to GitHub

php-twitter - issue #2

twitterAvailable function in current release always returns false. Fix included.


Posted on Sep 20, 2008 by Grumpy Elephant

The twitterAvailable function is wrong. It always returns a false result. Existing form: function twitterAvailable() { $request = 'http://twitter.com/help/test.' . $this->type;

    if( $this->objectify( $this->process($request) ) == 'ok' ){
        return true;
    }else{
        return false;
    }
}

The function needs "->scalar" added to the objectify part, like this: New form: function twitterAvailable() { $request = 'http://twitter.com/help/test.' . $this->type;

    if( $this->objectify( $this->process($request) )->scalar == 'ok' ){
        return true;
    }else{
        return false;
    }
}

Comment #1

Posted on Feb 28, 2009 by Happy Monkey

I'm updating the library right now. Will look at this this weekend. Feel free to create a patch and submit back. You'll get props.

Comment #2

Posted on Feb 28, 2009 by Happy Monkey

I can't confirm this, but it's an old issue so Twitter may have fixed their return value. Twitter is up right now and the function is returning true. Closing as invalid.

Comment #3

Posted on Feb 28, 2009 by Happy Monkey

(No comment was entered for this change.)

Status: Invalid

Labels:
Type-Defect Priority-Medium