Export to GitHub

mysql-master-ha - issue #99

Plaintext password in output


Posted on Oct 14, 2014 by Grumpy Cat

What steps will reproduce the problem? 1. Run masterha_master_switch 2. Look at output of MHA when it runs the /usr/local/bin/mha_master_ip_online_change or /usr/local/bin/mha_master_ip_failover script

What is the expected output? What do you see instead?

Other places in the code, passwords are replaced with 'xxx' for logging, but this is not the case here. Instead, you see the actual password.

What version of the product are you using?

This is present in version 0.56.

Please provide any additional information below.

I've attached two patch files. One for MasterFailover.pm and one for MasterRotate.pm which fix the issue.

Attachments

Comment #1

Posted on Oct 15, 2014 by Grumpy Bear

Thanks Jonah. Your patch looks good. Would you mind if submitting a pull request on GitHub repo https://github.com/yoshinorim/mha4mysql-manager ?

  • Yoshinori

Comment #2

Posted on Oct 16, 2014 by Grumpy Cat

Pull request submitted. https://github.com/yoshinorim/mha4mysql-manager/pull/48

Comment #3

Posted on Oct 17, 2014 by Grumpy Bear

Done. Thanks for your contribution!

Status: Done

Labels:
Type-Defect Priority-Medium