Export to GitHub

morelinq - issue #8

Code review request for Split


Posted on Feb 17, 2009 by Massive Ox

Purpose of code changes on this branch:

When I added the Batch operator, I thought I could implement it in terms of a generalized Split operator. I was wrong, but the damage was already done and I had implemented and factored out all the work to implement a Split operator for any enumerable source. However, I have doubts about its general usefulness and is the reason why I am putting it in a branch.

When reviewing my code changes, please focus on:

I would appreciate it if you could review and comment on "utility" and general application of this operator. If you find that it makes good sense then I can merge it back into the turnk. Otherwise the branch can just serve as an archive.

After the review, I'll merge this branch into: /trunk

Comment #1

Posted on Feb 19, 2009 by Massive Ox

(No comment was entered for this change.)

Comment #2

Posted on Apr 14, 2009 by Massive Ox

Interesingly, similar Split implementation below except it is specialized/optimized for strings:

http://stackoverflow.com/questions/298830/split-string-containing-command-line- parameters-into-string-in-c/298990#298990

Comment #3

Posted on Apr 22, 2010 by Swift Cat

Set review issue status to: Accepted

Comment #4

Posted on Apr 22, 2010 by Swift Cat

Ok, I have found a pretty cool solution, it needs a little polishing but should be available tomorrow after I had a little sleep ;-)

Comment #5

Posted on May 24, 2012 by Massive Ox

Bump!

Would be good if this can be reviewed prior to migrating[1] to Hg in the interest of having fewer open branches to carry forward.

[1] https://groups.google.com/forum/?fromgroups#!topic/morelinq-dev/IHE7LMH_eBU

Comment #6

Posted on May 25, 2012 by Massive Ox

(No comment was entered for this change.)

Comment #7

Posted on May 25, 2012 by Massive Ox

(No comment was entered for this change.)

Status: Duplicate

Labels:
Type-Review Priority-Medium