Export to GitHub

memcached - issue #416

1.4.24 fails to build with -Werror


Posted on Jun 27, 2015 by Swift Wombat

What steps will reproduce the problem? 1. Try to compile

What is the expected output? What do you see instead?

Expected compile to succeed.

What version of the product are you using? On what operating system? 1.4.24

Please provide any additional information below.

items.c:1141:28: error: comparison of constant 256 with expression of type 'uint8_t' (aka 'unsigned char') is always true [-Werror,-Wtautological-constant-out-of-range-compare] assert(it->slabs_clsid < LARGEST_ID); ~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~ /usr/include/assert.h:54:21: note: expanded from macro 'assert'

define assert(e) ((e) ? (void)0 : assert(__func, FILE, \

                      ^

1 error generated.

Full log available of course.

Comment #1

Posted on Jun 27, 2015 by Swift Wombat

Here's the full log

Attachments

Comment #2

Posted on Jul 5, 2015 by Helpful Bird

weird. wonder why the clang fix didn't get that one... it's the same.

I've fixed this in the 'next' branch, thanks.

Status: Fixed

Labels:
Type-Defect Priority-Medium