Export to GitHub

iui - issue #346

Checking for back-links (in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)


Posted on Jul 22, 2012 by Swift Monkey
  1. Click on a link and let a new page slide in.
  2. In the new page click on a link to #home

Expected result: iUI returns to #home with a backwards scroll

Incorrect result: iUI pushes #home on the nav stack and does a forward scroll to home

Comment #1

Posted on Jul 22, 2012 by Swift Monkey

I added a test-case for easy reproduction here: https://github.com/iui/iUI/commit/a1d0fd6217317ce01ec1f77fc7df0c6ca6333280

Comment #2

Posted on Jul 22, 2012 by Swift Monkey

This change cleans up iui.busy handling for ajax links (but does not fix the bug) https://github.com/iui/iUI/commit/b3de1ca14c95434d748c2395a5530b8997adb35a

Comment #3

Posted on Jul 22, 2012 by Swift Monkey

This is the commit that actually fixes the bug: https://github.com/iui/iUI/commit/c348613cd2e8db45aeb3a37daf1937eff257b563

Comment #4

Posted on Jul 22, 2012 by Swift Monkey

Remi, why don't you check out the changes on comment on them on GitHub.

(Yes, I think it's time to make GitHub our primary code repository...)

Comment #5

Posted on Jul 22, 2012 by Swift Monkey

I want to take a closer look at the code that decides whether "view" is a node or a node ID string. That may not be done properly for cross-browser.

Status: Started

Labels:
Type-Defect Milestone-REL-0.40 Priority-Critical