
google-coredumper - issue #4
Source tarball 1.2.1 contains slight differences to the files in the repository
There are slight discrepancies between the contents of the tarball and the contents of the svn repository.
The release process should be amended such that the tarballs exactly reflect the repository state.
See also issue 3.
diff -rux.svn google-coredumper/Makefile.am coredumper-1.2.1/Makefile.am --- google-coredumper/Makefile.am 2008-10-01 15:05:28.000000000 +0100 +++ coredumper-1.2.1/Makefile.am 2008-04-02 00:37:59.000000000 +0100 @@ -1,5 +1,8 @@ ## Process this file with automake to produce Makefile.in
+# Make sure that when we re-make ./configure, we get the macros we need
+ACLOCAL_AMFLAGS = -I pwd
/../autoconf
+
# This is so we can #include <google/foo>
AM_CPPFLAGS = -I$(top_srcdir)/src
diff -rux.svn google-coredumper/Makefile.in coredumper-1.2.1/Makefile.in --- google-coredumper/Makefile.in 2008-10-01 15:05:28.000000000 +0100 +++ coredumper-1.2.1/Makefile.in 2008-04-04 16:24:29.000000000 +0100 @@ -227,6 +227,9 @@ sysconfdir = @sysconfdir@ target_alias = @target_alias@
+# Make sure that when we re-make ./configure, we get the macros we need
+ACLOCAL_AMFLAGS = -I pwd
/../autoconf
+
# This is so we can #include <google/foo>
AM_CPPFLAGS = -I$(top_srcdir)/src
googleincludedir = $(includedir)/google
Only in google-coredumper/: svn-commit.tmp
Comment #1
Posted on Aug 29, 2012 by Massive HorseAnother difference:
diff -p -r coredumper-1.2.1/src/linux_syscall_support_unittest.cc google-coredumper-read-only/src/linux_syscall_support_unittest.cc * coredumper-1.2.1/src/linux_syscall_support_unittest.cc 2008-03-29 06:38:57.000000000 +0800 --- google-coredumper-read-only/src/linux_syscall_support_unittest.cc 2012-08-29 14:45:36.889474958 +0800 ************* namespace linux_syscall_support { * 62,68 ** #include #include #include - #include #include #include #include --- 62,67 ---- *********** static void CheckStructures() { * 91,98 ** // there are a small number of data structures (e.g "struct // kernel_old_sigaction") that we cannot test at all, as glibc does // not have any definitions for them. - CHECK(sizeof(struct dirent64) == sizeof(struct kernel_dirent64)); - CHECK(sizeof(struct dirent) == sizeof(struct kernel_dirent)); CHECK(sizeof(struct iovec) == sizeof(struct kernel_iovec)); CHECK(sizeof(struct msghdr) == sizeof(struct kernel_msghdr)); CHECK(sizeof(struct pollfd) == sizeof(struct kernel_pollfd)); --- 90,95 ---- diff -p -r coredumper-1.2.1/src/linuxthreads.c google-coredumper-read-only/src/linuxthreads.c * coredumper-1.2.1/src/linuxthreads.c 2008-03-29 06:38:57.000000000 +0800 --- google-coredumper-read-only/src/linuxthreads.c 2012-08-29 14:45:36.893469332 +0800 ************* extern "C" { * 49,55 ** #include #include #include - #include
#include "linux_syscall_support.h" #include "thread_lister.h" --- 49,54 ----
Status: New
Labels:
Type-Defect
Priority-Medium