Export to GitHub

google-coredumper - issue #2

linux/dirent.h removed from kernel


Posted on Aug 25, 2008 by Helpful Dog

Hello, I had been packaging coredumper and one issue comes. The file linux/dirent.h has been removed from linux kernel hearders (at least for fedora latest rawhide kernel).

header file defines two structs

ifndef _LINUX_DIRENT_H

define _LINUX_DIRENT_H

struct dirent { long d_ino; __kernel_off_t d_off; unsigned short d_reclen; char d_name[256]; /* We must not include limits.h! */ };

struct dirent64 { __u64 d_ino; __s64 d_off; unsigned short d_reclen; unsigned char d_type; char d_name[256]; };

endif

If you can confirm that this is not case with kernel headers and is specially a problem for fedora kernel.

Then I will patch the package specially, but if it is other way round, then you may consider fixing the issue.

Regards, rakesh

Comment #1

Posted on Aug 25, 2008 by Helpful Dog

i did a bit more investigation and found that in place of linux/dirent.h should now be using dirent.h already in includedir provided by glibc headers.

Attachments

Comment #2

Posted on Aug 30, 2008 by Helpful Dog

ping? I am impatiently waiting for update.

Comment #3

Posted on Aug 30, 2008 by Helpful Dog

I think my patch is wrong. We need to check which dirent and dirent64 structures does kernel use now. If it used glibc header structures then no need to do structure checking.

Comment #4

Posted on Aug 31, 2008 by Helpful Dog

ping? ping? I am getting bit impatient?????

Comment #5

Posted on Aug 31, 2008 by Happy Wombat

I just submitted a change that removed all references to linux/dirent.h. Let me know, if you still run into any other problems.

Comment #6

Posted on Aug 31, 2008 by Helpful Dog

Okay Thanks I will build now and report in few mins

Comment #7

Posted on Aug 31, 2008 by Helpful Dog

Confirmed! It is working and Fixed.

Status: Fixed

Labels:
Type-Defect Priority-Medium