Export to GitHub

godag - issue #6

File licenses need to be fixed.


Posted on Nov 29, 2011 by Happy Camel

$ hg grep "all rights reserved" src/cmplr/compiler.go:386:// © Knug Industries 2009 all rights reserved src/cmplr/dag.go:386:// © Knug Industries 2009 all rights reserved src/start/main.go:385:// © Knug Industries 2009 all rights reserved src/utilz/handy.go:382:// © Knug Industries 2009 all rights reserved util/gd-completion.sh:381:# Copyright (C) 2009 all rights reserved src/parse/gopt.go:378:// © Knug Industries 2009 all rights reserved src/utilz/walker.go:378:// © Knug Industries 2009 all rights reserved src/cmplr/gdmake.go:368:// © Knug Industries 2011 all rights reserved src/parse/gopt_test.go:368:// © Knug Industries 2009 all rights reserved src/parse/option.go:368:// © Knug Industries 2009 all rights reserved src/utilz/global.go:368:// © Knug Industries 2010 all rights reserved src/utilz/say.go:368:// © Knug Industries 2011 all rights reserved src/utilz/stringbuffer.go:368:// © Knug Industries 2010 all rights reserved src/utilz/stringset.go:368:// © Knug Industries 2009 all rights reserved util/gdmk-completion.sh:357:# Copyright (C) 2011 all rights reserved build.sh:353:# Copyright (C) 2009 all rights reserved util/gdmake-completion.sh:338:# Copyright (C) 2011 all rights reserved build.bat:324:REM Copyright (C) 2009 all rights reserved src/utilz/timer.go:243:// © Knug Industries 2011 all rights reserved cppkgroot.sh:67:# Copyright (C) 2009 all rights reserved

This makes it impossible to use/distribute godag as an open source project. All files need to have the GPL boilerplate, to be covered by the GPL itself: please see the "How to Apply These Terms to Your New Programs" section in the LICENSE file shipped with godag itself to see how to fix this.

Comment #1

Posted on Nov 29, 2011 by Swift Cat

OK, I'll modify that.

this highlights a bigger issue; nobody reads the license :-)

Comment #2

Posted on Nov 29, 2011 by Swift Cat

(No comment was entered for this change.)

Comment #3

Posted on Nov 29, 2011 by Happy Camel

Well, somebody does, clearly, right? :) I was looking at it with the idea of trying it and packaging it for debian if it ends up as a dependency for my project, and debian ftp-masters would definitely check every file :)

Comment #4

Posted on Nov 30, 2011 by Swift Cat

:-) true

the debian package built by the makefile (_gdmk.go) does not pass the lintian test due to the statically linked binary (gd). it may be allowed to add exceptions to this requirement, but i'm not 100% sure..

changed the copyright header on both branches now, let me know if it looks legit :-)

Comment #5

Posted on Dec 1, 2011 by Happy Camel

Thanks for the fix, seems allright. As for "official" debian packaging, we'll need to do it in a way that follows the debian policy, of course, so the one built by the makefile will not be used for it.

Thanks,

Guido

Comment #6

Posted on Dec 1, 2011 by Swift Cat

hi

you're right; that will certainly not pass any quality control at debian. :-)

hopefully you can get some wireframe stuff for free from the generated archive/deb, not a huge timesaver though..

i'll mark this issue as 'fixed', hopefully that's true

bjarneh

Comment #7

Posted on Dec 1, 2011 by Happy Camel

Thanks a lot! :) Don't worry, if there are problems I'll come back, thanks for your cooperation for now! I'll try to use godag, now that it's free software, and see what happens! :)

Thanks,

Guido

Comment #8

Posted on Dec 1, 2011 by Swift Cat

hehe, now it should be free as in freedom (and beer)

it's shameful that i did not know the basics of adding a license, well well; now i know :-)

to be honest i only downloaded the 'hello' package from debian, which is some sort of template for how to make debian packges i think. then i used that template as a starter, and worked with it until 'lintian' complained as little as possible, which is probably not the way the experts do it :-)

if you write a real deb-package-script, please let me know, i'd gladly replace the hack i've written to create deb-packages, it's not pretty..

bjarneh

Status: Fixed

Labels:
Type-Defect Priority-Medium