Export to GitHub

godag - issue #4

filepath.Walk() Breaking changes


Posted on Nov 23, 2011 by Grumpy Cat

I know godag support is for release versions of Go, but I do love godag, so a branch or patch would be awesome.

I'm using 6g version weekly.2011-10-18 10125

and there are some breaking changes in filepath.Walk

_gdmk.go:210: cannot use collect (type *collector) as type filepath.WalkFunc in function argument _gdmk.go:210: too many arguments in call to filepath.Walk _gdmk.go:848: cannot use collect (type *collector) as type filepath.WalkFunc in function argument _gdmk.go:848: too many arguments in call to filepath.Walk _gdmk.go:946: cannot use collect (type *collector) as type filepath.WalkFunc in function argument _gdmk.go:946: too many arguments in call to filepath.Walk

filepath.Walk now expects a callback to a func, and does not receive a collector anymore.

func Walk(root string, walkFn WalkFunc) os.Error

This will have to be fixed eventually.

Comment #1

Posted on Nov 23, 2011 by Swift Cat

i'll try to add a branch/patch which follows the tip of go, it will be flaky at best until go reaches v1 i guess, perhaps gofix will do what the name suggests :-)

bjarneh

Comment #2

Posted on Nov 23, 2011 by Grumpy Cat

Gofix won't fix it because it's a change in implementation not just naming and routes :S But hey if you could try and be on the tip preparing for the release of Go 1 in a few months it would be appreciated. :D

Comment #3

Posted on Nov 23, 2011 by Swift Cat

you're right; gofix can be handy, but this requires some manual changes :-) i'll see if i can get this done tonight or tomorrow..

Comment #4

Posted on Nov 24, 2011 by Swift Cat

created a new head now, which should compile with the weekly revision from go.. let me know if you get some trouble with it.. (it's also in the 'weekly' branch at github)

Comment #5

Posted on Nov 25, 2011 by Grumpy Cat

Just a lot of undefined "error" errors. I dunno if it has changed in the last weeks (I heard they're changing it to error.Value, but in my weekly version it is still os.Error, o I fixed all "error" types in /utilz/walker.go and gdmk.go to "os.Error" and it compiled and installed correclty. Thanx.

Comment #6

Posted on Nov 25, 2011 by Grumpy Cat

another thing, I had to change the import path to "exec" I guess the last weekly may have it moved to "os/exec" but docs here: http://golang.org/doc/devel/weekly.html only go so far to september :S

I'm using 6g version weekly.2011-10-18 10125 with Gomingw for Windows x64 and thats the latest they have so I have to fix lots of packages to work with. Go 1 will be a blessing.

Comment #7

Posted on Nov 27, 2011 by Massive Hippo

It's a duplicate of Issue 1.

Comment #8

Posted on Nov 27, 2011 by Swift Cat

hi, my 'branching' knowledge in mercurial may have messed up tings here :-)

i've created a new 'head' which i tried to call weekly not sure if that even worked out (there are two branches now from the latest release tag).

hg up release

should compile against go's latest release, i.e. this version of godag

1798dcd20ca3 release/release.Oct.25.2011/release.r60.3

compiles against this version of go

c1702f36df03 (release-branch.r60) release/release.r60.3

this version of godag

718bd7a2eaad tip

should compile with this version of go:

b4a91b693374 weekly/weekly.2011-11-18

or perhaps not? :-)

b4a91b693374 weekly/weekly.2011-11-18

Comment #9

Posted on Mar 29, 2012 by Swift Cat

closing fixed issue

Status: Fixed

Labels:
Type-Defect Priority-Medium