Export to GitHub

formalchemy - issue #98

Custom types with inheritance = random renderer


Posted on Apr 28, 2009 by Quick Dog

What steps will reproduce the problem? 1. Create a custom type 2. Create a custom type that inherit from the custom type in 1 3. Create a renderer for both types 4. ??? 5. Render both fields

Expected: 2 different fields

Got: 2 different fields or 2 samefields.

The _get_renderer doesn't look for inheritance but just for isinstance,

I wrote a patch that make it possible to accurately find the good renderer for each types.

Attachments

Comment #1

Posted on Apr 30, 2009 by Swift Dog

style note: object is a built in type to python, avoid using this as a variable name

I don't like adding the redundant types, certainly TIMESTAMP is not needed b/c we have DateTime; I'm a little fuzzier on which of the text types we need but I thought everything should be a String these days.

Comment #2

Posted on May 1, 2009 by Quick Dog

If you remove the TIMESTAMP, the test won't pass, that's why I added those types. Otherwise I would keep the other type as they are except unicode may be.

Comment #3

Posted on Jun 16, 2009 by Swift Dog

The given patch does not meet my standards and I'm interested enough in supporting inheritance to fix it myself. Feel free to reopen with a new patch.

Status: WontFix