Export to GitHub

djangobot - issue #8

unnecessarily fetches ticket/changeset body


Posted on Feb 9, 2008 by Grumpy Camel

What steps will reproduce the problem? 1. type e.g. #5000 or r6000 on the channel

What is the expected output? What do you see instead?

The code.djangoproject.com web server receives a GET request and responds with the HTML page corresponding to the ticket or channel. Djangobot doesn't use the data of the response. A HTTP HEAD request should be used instead for better performance and less bandwidth usage.

What version of the product are you using? On what operating system?

Please provide any additional information below.

Patch attached.

Brian, sorry I got a little carried away creating patches... it's my first encounter with Twisted code, and boy that's elegant! So while fooling around with the code I spotted these minor issues which I decided to submit in this and the previous tickets while I was at it. Thanks for running the bot!

Attachments

Comment #1

Posted on Feb 9, 2008 by Grumpy Bird

Fixed in #16. Use a HEAD request when checking for tickets/changeset availability. Thanks, akaihola.

Status: Fixed

Labels:
Type-Defect Priority-Medium