Export to GitHub

djangobot - issue #5

Make the bot case-insensitive with regard to its own nick


Posted on Feb 7, 2008 by Swift Dog

In IRC, nicknames aren't case sensitive, so sending a message to "djangobot" and "DjangoBot" go to the same place. Unfortunately, it seems the bot is a bit too particular about what it's called, so sending a message to "djangobot" goes unanswered.

Comment #1

Posted on Feb 7, 2008 by Grumpy Bird

Very interesting. Thanks for doing the research into where it is documented. I even looked through the RFC and didn't find much other than what you gave which gives a strong enough indication that it is indeed case-insensitive.

damn you, challenging me to find you a link :( this is the closest i've found so far: "Because of IRC's scandanavian origin, the characters {}| are considered to be the lower case equivalents of the characters [], respectively. This is a critical issue when determining the equivalence of two nicknames."

Comment #2

Posted on Feb 7, 2008 by Grumpy Bird

(No comment was entered for this change.)

Comment #3

Posted on Feb 9, 2008 by Grumpy Camel

I tested the simple lower() approach and it seems to work for both private messages and catching the "djangobot:" prefix from messages.

Freenode doesn't seem to accept non-ascii characters in nicknames, so using lower() should be sufficient.

Attachments

Comment #4

Posted on Feb 10, 2008 by Grumpy Camel

Revised patch against r18.

Attachments

Comment #5

Posted on Feb 13, 2008 by Grumpy Camel

Revised patch against r19.

Attachments

Comment #6

Posted on Feb 14, 2008 by Grumpy Bird

Fixed in r22. Perform a case-insenstive comparsion when comparing the bot nickname.

Forgot to give thanks. But I do thank you for the patch! :)

Status: Fixed

Labels:
Type-Defect Priority-Medium