Export to GitHub

distcc - issue #96

src/stats.c variable 'ret' set but not used


Posted on Feb 14, 2012 by Happy Horse

Answering the following questions is a big help:

  1. What version of distcc are you using (e.g. "2.7.1")? I checked out the sourcecode yesterday (13.02.2012)

  2. What platform are you running on (e.g. "Red Hat 8.0", "HP-UX 11.11")?
    OpenSuse 12.1 / gcc 4.6.2

  3. What were you trying to do (e.g. "install distcc", "build Mozilla")? I try a make

  4. What went wrong? I got this error: src/stats.c:366:13: error: variable ‘ret’ set but not used [-Werror=unused-but-set-variable]

This error is not the first one like that it was fixed for the other file but i don't know why I get the same error here.

I add the full output of make in a file

.

Attachments

Comment #1

Posted on Feb 15, 2012 by Helpful Panda

Try the following patch.

Index: src/stats.c

--- src/stats.c (revision 755) +++ src/stats.c (working copy) @@ -440,6 +440,7 @@ free_space_mb); dcc_set_nonblocking(acc_fd); ret = read(acc_fd, challenge, 1024); /* empty the receive queue */ + if (ret < 0) rs_log_info("read on acc_fd failed"); dcc_writex(acc_fd, reply, reply_len); }

Comment #2

Posted on Apr 4, 2012 by Helpful Panda

I've gone ahead and committed the patch. Fixed in revision 758.

Status: Fixed