Export to GitHub

chromium-os - issue #39836

LTE: device shows 3G icon on activating LTE


Posted on Mar 12, 2013 by Quick Lion

Chrome Version: 26.0.1410.30 (WebKit 537.31) OS Version: 3701.47.0 x86_64 Type of computer: Pixel

This is a follow on to http://crbug.com/180662

This is always reproducible. The screenshot contains the view of chrome://network that stevenjb asked for.

Steven, could you look at this, and reassign if appropriate?

Attachments

Comment #1

Posted on Mar 12, 2013 by Quick Lion

(No comment was entered for this change.)

Comment #2

Posted on Mar 12, 2013 by Quick Lion

(No comment was entered for this change.)

Comment #3

Posted on Mar 12, 2013 by Quick Lion

(No comment was entered for this change.)

Comment #4

Posted on Mar 13, 2013 by Quick Bird

(No comment was entered for this change.)

Comment #5

Posted on Mar 13, 2013 by Quick Bird

(No comment was entered for this change.)

Comment #6

Posted on Mar 16, 2013 by Massive Lion

How does the UI determine which icon is used after activation? I can guarantee that this not a shill issue: when the service is created its NetworkTechnology property is always set to LTE. Even hardcoding LTE right before we update the service's activation state didn't prevent the UI from showing '3G', which leads me to believe that this is a UI issue.

Comment #7

Posted on Mar 16, 2013 by Happy Ox

So, when I investigated this, I saw a message in the Event Log (in chrome://network) indicating that Service.Cellular.NetworkTechnology for the cellular service changed to LTE (which will only occur if the technology was previously something other than LTE). This event occurred after Service.Cellular.ActivationState changed to "activated". This was on a 26 build.

Are you sure that the NetworkTechnology property change is being pushed to Chrome before ActivationState changes?

Comment #8

Posted on Mar 16, 2013 by Massive Lion

Currently it isn't necessarily so (i.e. it will be pushed whenever the modem returns the current access technology). The thing is, on my own custom build, where I set the access technology to LTE right before I set the service activation state, I still see the '3G' icon in the UI.

Comment #9

Posted on Mar 16, 2013 by Happy Ox

Chrome only knows about a state change if it receives a PropertyChanged message for the service, so the thing to do is to confirm that PropertyChanged(service_path, "Cellular.NetworkTechnology", "LTE" (or "LTE Advanced") is being sent across the DBus before the PropertyChanged(service_path, "Cellular.ActivationState", "activated") message.

We should be logging both of those events in Chrome. I can check whether or not I am seeing that on ToT on Monday and attach logs.

Comment #10

Posted on Mar 16, 2013 by Massive Lion

I actually don't see that ActivationState change events get logged on my ToT build. I emailed my logs to stevenjb@.

Comment #11

Posted on Mar 16, 2013 by Happy Ox

(log attached)

OK, so, after activation: 1. "Verizon Wireless" is showing up as a new service ["PropertiesReceived: /service/7 (Verizon Wireless)"] 1a. ActivationState == "active" (inferred because we don't see any ActivationState changes in the log) 1b. Cellular.NetworkTechnology != "LTE" (inferred because of the next event) 2. Cellular.NetworkTechnology -> "LTE" "[NetworkPropertyUpdated: Verizon Wireless.Cellular.NetworkTechnology = LTE"]

Chrome is creating the notification when we receive 1, but we don't know it us an LTE network untl 2.

We could hack around this by delaying the notification a bit (the LTE update appears to occur immediately after the initial update), but it would be nice to avoid that...

Comment #12

Posted on Mar 19, 2013 by Quick Rabbit

Project: chromiumos/platform/shill Branch : master Author : Arman Uguray Commit : 7af0fac103deceec063554ef5705901d6d82d42f

Code Review +2: Thieu Le Verified +1: Arman Uguray Change-Id : I2f2cb2a08523210ada5845b92ec59d781a0b5ce2 Reviewed-at : https://gerrit.chromium.org/gerrit/45810

shill: Always return LTE as the NetworkTechnology on E362.

CellularCapabilityUniversal::GetNetworkTechnologyString() now will always return flimflam::kNetworkTechnologyLte, if |model_id_| is set to CellularCapabilityUniversal::kE362ModelId.

BUG=chromium-os:39836 TEST=1. Build and run unit tests. 2. Activate an LTE SIM on an arrow device. Once activation is completed (the cellular service becomes "Activated"), the activation notification that pops up in the lower right corner should display a blue icon that says "LTE" and not "3G".

Commit-Queue: Arman Uguray

M cellular_capability_universal.cc M cellular_capability_universal.h M cellular_capability_universal_unittest.cc

Comment #13

Posted on Mar 19, 2013 by Massive Lion

(No comment was entered for this change.)

Comment #14

Posted on Mar 19, 2013 by Quick Rabbit

Moved to: Issue chromium:221934

Status: Moved

Labels:
Type-Bug Pri-1 Cr-OS-Systems-Cellular OS-Chrome M-26