Export to GitHub

bravojs - issue #1

bravo.js doesn't need to be the first script loaded


Posted on Jan 6, 2011 by Massive Dog

What steps will reproduce the problem? 1. pull in an unrelated script (one that doesn't use bravo) before bravo.js 2. try to use bravo.js

What is the expected output? What do you see instead?

BravoJS should work even if bravo.js is not the first script in the document.

What version of the product are you using? On what operating system?

tip (22:d7ee85f038dd)

Please provide any additional information below.

It would be nice if BravoJS worked even when it is not the first script loaded.

Attachments

Comment #1

Posted on Jan 6, 2011 by Massive Dog

If bravo.js is loaded by conventional means (script tag) it is the last script in the document while executing. In my opinion, a more solid way to find bravo.js is to check the last script in the doc (I'd suggest this would be more reliable than looking for the id as well).

Comment #2

Posted on Jun 19, 2012 by Swift Monkey

(No comment was entered for this change.)

Status: Accepted

Labels:
Type-Defect Priority-Medium