Export to GitHub

airbag - issue #90

MinidumpCallback passes a wstring parameter


Posted on Dec 5, 2006 by Quick Monkey

MinidumpCallback passes a wstring parameter

This means that it is very tempting for the implementor of MinidumpCallback to call the .c_str() function, which in many std::wstring implementations results in a heap allocation (to make space for the null terminator). I think the airbag API should pass a |const wchar_t*| instead to help steer consumers away from making the mistake of using the heap after a crash.

Comment #1

Posted on Dec 5, 2006 by Happy Horse

Will roll in to patch for #81.

Comment #2

Posted on Dec 7, 2006 by Happy Horse

Checked in with #81, revision [79].

Status: Fixed

Labels:
Type-Defect Priority-Medium Component-Client-Handler OpSys-Windows