We should allow callers of MinidumpProcessor to supply their own version of SourceLineResolver, providing the current implementation as a base to build on. This would be useful in any situation where loading a full symbol file into the calling process is not desired.
Still TBD: if we do this, is the SymbolSupplier interface still useful? It would be possible for a custom implementation of SourceLineResolver to load symbol files any way that it wants to, without having to return a local file path as a string.
Comment #1
Posted on Dec 4, 2006 by Happy CatThis patch factors out an abstract interface to SourceLineResolver, and makes the header for the concrete implementation public. I didn't make any changes to the SymbolSupplier functionality.
- source-line-resolver.diff 27.42KB
Comment #2
Posted on Dec 11, 2006 by Happy Catpatch version 2
Status: Accepted
Labels:
Type-Defect
Priority-Medium