cainlevy - Project Hosting on Google Code

User Profile		Updates

Earlier this year Aug 01, 2009 recordselect issue 65 (Shift+Home or Shift+End submit record_select even when no wo...) commented on - Please fork and patch via Github when you have time. There should be some JavaScript specifically for catching key presses -- search in record_select.js for onkeypress. Please fork and patch via Github when you have time. There should be some JavaScript specifically for catching key presses -- search in record_select.js for onkeypress. Mar 04, 2009 recordselect issue 62 (RecordSelect returns incorrect results when used with Rails ...) commented on - Ok, I was interested enough in how this code was admitted that I dug back through git history. It appears that both of the concerns I have with this helper were introduced back in June 2008. So if I'm correct (and again, I don't have the setup to test), this bug has existed for nearly a year. But that doesn't explain why it would just manifest in the newest A.S. version. Ok, I was interested enough in how this code was admitted that I dug back through git history. It appears that both of the concerns I have with this helper were introduced back in June 2008. So if I'm correct (and again, I don't have the setup to test), this bug has existed for nearly a year. But that doesn't explain why it would just manifest in the newest A.S. version. Mar 04, 2009 recordselect issue 62 (RecordSelect returns incorrect results when used with Rails ...) commented on - So the problem is that when ActiveScaffold sets up RS, the params are something like {:controller => 'contacts', :action => 'new', :id => 15}. So AS stuffs all of those into options[:params]. Which is wrong. The options[:params] hash is supposed to be for extra parameters in the RS url, like "?role=Admin" to restrict results via the record_select_conditions_from_params() controller helper. But since ActiveScaffold is actually passing through all current params, including the :id, then RS ends up with an incorrect url. url = url_for(options[:params].merge(...)) is supposed to mean: url = url_for({:role => 'Admin'}.merge(:action => 'browse', :controller => 'locations')) but instead ends up meaning: url = url_for({:controller => 'contacts', :action => 'new', :id => 15}.merge(:action => 'browse', :controller => 'locations')) And that's just not going to work. ActiveScaffold should not be passing current request parameters to the RecordSelect helper. So the problem is that when ActiveScaffold sets up RS, the params are something like {:controller => 'contacts', :action => 'new', :id => 15}. So AS stuffs all of those into options[:params]. Which is wrong. The options[:params] hash is supposed to be for extra parameters in the RS url, like "?role=Admin" to restrict results via the record_select_conditions_from_params() controller helper. But since ActiveScaffold is actually passing through all current params, including the :id, then RS ends up with an incorrect url. url = url_for(options[:params].merge(...)) is supposed to mean: url = url_for({:role => 'Admin'}.merge(:action => 'browse', :controller => 'locations')) but instead ends up meaning: url = url_for({:controller => 'contacts', :action => 'new', :id => 15}.merge(:action => 'browse', :controller => 'locations')) And that's just not going to work. ActiveScaffold should not be passing current request parameters to the RecordSelect helper. Mar 04, 2009 recordselect issue 62 (RecordSelect returns incorrect results when used with Rails ...) Status changed - Sorry guys, this looks like an ActiveScaffold issue. The helper method that ActiveScaffold uses to render RS widgets is sending the wrong parameters. I recommend looking at the active_scaffold_input_record_select() helper and submitting a patch to the ActiveScaffold project. There are a couple of things that concern me in that method. For example, line 130 uses params.merge! without dup'ing, which would actually modify the request params hash. But the actual problem may be line 127, which passes all current request params through to the record_select helper. I don't use ActiveScaffold any more, so I'm not in a good position to make (and test) this change myself. Status: WontFix Sorry guys, this looks like an ActiveScaffold issue. The helper method that ActiveScaffold uses to render RS widgets is sending the wrong parameters. I recommend looking at the active_scaffold_input_record_select() helper and submitting a patch to the ActiveScaffold project. There are a couple of things that concern me in that method. For example, line 130 uses params.merge! without dup'ing, which would actually modify the request params hash. But the actual problem may be line 127, which passes all current request params through to the record_select helper. I don't use ActiveScaffold any more, so I'm not in a good position to make (and test) this change myself. Status: WontFix Mar 04, 2009 recordselect issue 62 (RecordSelect returns incorrect results when used with Rails ...) commented on - well, options[:params] is not the same thing as params. merging in the latter would override the :action, :controller, and maybe :id keys. but the former is a way to add parameters to the browse request itself. could you please provide the url that is generated by the standard url_for line, and the url that you expect to be generated instead? well, options[:params] is not the same thing as params. merging in the latter would override the :action, :controller, and maybe :id keys. but the former is a way to add parameters to the browse request itself. could you please provide the url that is generated by the standard url_for line, and the url that you expect to be generated instead? Feb 03, 2009 recordselect issue 55 (record_select_conditions_from_controller seems not to work c...) commented on - that doesn't help. you can't confirm that it works or doesn't work? and what is the result of the code you pasted? please feel free to debug this in your own code. it's much easier for you to poke through the plugin code and see what may be going wrong, since you already have a failing scenario. that doesn't help. you can't confirm that it works or doesn't work? and what is the result of the code you pasted? please feel free to debug this in your own code. it's much easier for you to poke through the plugin code and see what may be going wrong, since you already have a failing scenario. Feb 01, 2009 recordselect issue 60 (ActiveScaffold record_multi_select drop-down doesn't show up...) commented on - any javascript errors? any server exceptions? any javascript errors? any server exceptions? Jan 25, 2009 recordselect issue 58 (Add Multiple Record Selects Per Controller) Status changed - I think this runs contrary to Rails' resource controller paradigm. I'm not inclined to fight the framework on that one. If you come up with something worth sharing, feel free to post back. Status: WontFix I think this runs contrary to Rails' resource controller paradigm. I'm not inclined to fight the framework on that one. If you come up with something worth sharing, feel free to post back. Status: WontFix Jan 09, 2009 recordselect issue 57 (triple nesting with activescaffold / record_select_field usa...) commented on - That doesn't answer my question. Let me rephrase: which "create" link are you clicking? The redundant calls are the ones that don't have configuration blocks. That is, where you have: active_scaffold :periodes active_scaffold :periodes do \|config\| ... end You should only have: active_scaffold :periodes do \|config\| ... end That doesn't answer my question. Let me rephrase: which "create" link are you clicking? The redundant calls are the ones that don't have configuration blocks. That is, where you have: active_scaffold :periodes active_scaffold :periodes do \|config\| ... end You should only have: active_scaffold :periodes do \|config\| ... end Jan 04, 2009 recordselect issue 57 (triple nesting with activescaffold / record_select_field usa...) commented on - Also, please try removing the redundant active_scaffold calls. You only want one per controller. Also, please try removing the redundant active_scaffold calls. You only want one per controller. Jan 04, 2009 recordselect issue 57 (triple nesting with activescaffold / record_select_field usa...) commented on - >> I want to select many "periodes" once and create all the "inscriptionPeriodes" that are associated with the "inscription" I am in. Does that mean you have a form for an Inscription, and that the form should contain a Periods field (that uses RecordSelect)? Because the form you pasted earlier was for an InscriptionPeriod, but that wouldn't help achieve your goal. >> I want to select many "periodes" once and create all the "inscriptionPeriodes" that are associated with the "inscription" I am in. Does that mean you have a form for an Inscription, and that the form should contain a Periods field (that uses RecordSelect)? Because the form you pasted earlier was for an InscriptionPeriod, but that wouldn't help achieve your goal. Jan 04, 2009 recordselect issue 57 (triple nesting with activescaffold / record_select_field usa...) Status changed - This is a form to create a PeriodsRegistrations record -- would you please paste the ActiveScaffold configuration? Since this is not a RecordSelect issue, I'm marking the ticket invalid. But I will try and continue to help a bit. Status: Invalid This is a form to create a PeriodsRegistrations record -- would you please paste the ActiveScaffold configuration? Since this is not a RecordSelect issue, I'm marking the ticket invalid. But I will try and continue to help a bit. Status: Invalid Jan 03, 2009 recordselect issue 57 (triple nesting with activescaffold / record_select_field usa...) commented on - Can you confirm that there is no RecordSelect code after the input field to transform it? That is, is the input field definitely not the result of a record select helper? If so, then it's an ActiveScaffold problem insofar as ActiveScaffold is not calling RecordSelect properly. Where did you download ActiveScaffold? At one point there was a restriction on using configuring form associations beyond a single nesting. I'm not sure when the restriction was lifted, but if you're running the latest version from Git then it's likely something else. Can you confirm that there is no RecordSelect code after the input field to transform it? That is, is the input field definitely not the result of a record select helper? If so, then it's an ActiveScaffold problem insofar as ActiveScaffold is not calling RecordSelect properly. Where did you download ActiveScaffold? At one point there was a restriction on using configuring form associations beyond a single nesting. I'm not sure when the restriction was lifted, but if you're running the latest version from Git then it's likely something else. Older Dec 17, 2008 activescaffold issue 640 (You have a nil object when you didn't expect it! (_list.rhtm...) Status changed - I looked into this as part of http://code.google.com/p/recordselect/issues/detail?id=56. The R.S. ticket has a bit more background on the issue, but the gist is that there's a significant problem in ActiveScaffold's current _pick_template re-implementation. Anyone willing to work on replacing ActiveScaffold's generic_view_paths with something more robust, please contact me directly (lance AT cainlevy DOT net). I may have figured out a better way of doing things on another plugin, but I do not know when I'll have the time to retrofit it into ActiveScaffold. Status: Accepted I looked into this as part of http://code.google.com/p/recordselect/issues/detail?id=56. The R.S. ticket has a bit more background on the issue, but the gist is that there's a significant problem in ActiveScaffold's current _pick_template re-implementation. Anyone willing to work on replacing ActiveScaffold's generic_view_paths with something more robust, please contact me directly (lance AT cainlevy DOT net). I may have figured out a better way of doing things on another plugin, but I do not know when I'll have the time to retrofit it into ActiveScaffold. Status: Accepted Dec 17, 2008 recordselect issue 56 (Unable alongside latest ActiveScaffold and Rails 2.2.2) Status changed - Ok, it looks like the problem is that there is no more :use_full_path option for render :file. So when render_record_select calls render :file, ActiveScaffold eventually picks it up, ignores the file path, and looks for a generic _list file. Which it finds in its own directory. This is definitely an ActiveScaffold problem. Its current re-implementation of _pick_template() does a naive search for self.view_paths[generic_template], where generic_template is something like "_list". It's not even checking for the generic template in registered generic template folders ... it's checking all view_paths. That's bad. I'm going to close this ticket for RecordSelect and comment on the ActiveScaffold issue: http://code.google.com/p/activescaffold/issues/detail?id=640. Status: WontFix Ok, it looks like the problem is that there is no more :use_full_path option for render :file. So when render_record_select calls render :file, ActiveScaffold eventually picks it up, ignores the file path, and looks for a generic _list file. Which it finds in its own directory. This is definitely an ActiveScaffold problem. Its current re-implementation of _pick_template() does a naive search for self.view_paths[generic_template], where generic_template is something like "_list". It's not even checking for the generic template in registered generic template folders ... it's checking all view_paths. That's bad. I'm going to close this ticket for RecordSelect and comment on the ActiveScaffold issue: http://code.google.com/p/activescaffold/issues/detail?id=640. Status: WontFix Dec 08, 2008 activescaffold issue 551 (Date types do not save in a nested table) Status changed - 457745bf Status: Fixed 457745bf Status: Fixed Nov 14, 2008 activescaffold issue 622 (Rails edge: undefined method `pick_template' for class `Acti...) commented on - "Consider the following scenario: Plugin A is running slightly behind. Rails version x deprecates some functionality that plugin A needs. Meanwhile, plugin B has dropped support for Rails version x-1. Now what?" So what if plugin B has dropped support? It's already working for your current version of Rails, so it's not like you're harmed because active development for it has moved on to the next. @gaffo: please use github for pull requests "Consider the following scenario: Plugin A is running slightly behind. Rails version x deprecates some functionality that plugin A needs. Meanwhile, plugin B has dropped support for Rails version x-1. Now what?" So what if plugin B has dropped support? It's already working for your current version of Rails, so it's not like you're harmed because active development for it has moved on to the next. @gaffo: please use github for pull requests Nov 09, 2008 activescaffold issue 469 (Filtered Indicator) Status changed - sergio has patched this via b9f1bf84d Status: Fixed sergio has patched this via b9f1bf84d Status: Fixed Nov 07, 2008 activescaffold issue 329 (turn off blank rows in subforms) commented on - when editing a record with complex plural associations (subforms), activescaffold normally adds a blank row where you can add a new record. it's what you get from 'add new', except prebuilt. i'm working from memory here ... when editing a record with complex plural associations (subforms), activescaffold normally adds a blank row where you can add a new record. it's what you get from 'add new', except prebuilt. i'm working from memory here ... Nov 05, 2008 activescaffold issue 526 (helper loading in enviroment.rb) Status changed - a78d0399f5ace5b4d89aa1a6997081aa4c8ab155 Status: Fixed a78d0399f5ace5b4d89aa1a6997081aa4c8ab155 Status: Fixed Nov 05, 2008 activescaffold issue 398 (Exception when add_subgroup preceedes exclude) Status changed - ced6d07a1f9d4309f9801c8bbe219322359e3f2c Status: Fixed ced6d07a1f9d4309f9801c8bbe219322359e3f2c Status: Fixed Nov 05, 2008 activescaffold issue 399 (Columns added to sub groups should be excluded from top leve...) Status changed - 5b4f3f38d3fa09c9ec8a1b4a0295d509fca340f4 Status: Fixed 5b4f3f38d3fa09c9ec8a1b4a0295d509fca340f4 Status: Fixed Nov 05, 2008 activescaffold issue 450 (Add search_ui) Status changed - Status: Fixed Status: Fixed Nov 04, 2008 activescaffold issue 622 (Rails edge: undefined method `pick_template' for class `Acti...) commented on - This is probably a bigger question than fits in this ticket, but I'm not sure how much ActiveScaffold should aim to remain backwards compatible. Perhaps master should stay sync'd with Rails edge, and we could create branches for major Rails releases and let the community backport ActiveScaffold features as needed. Consider http://www.loudthinking.com/posts/20-dont-overestimate-the-power-of-versions. This is probably a bigger question than fits in this ticket, but I'm not sure how much ActiveScaffold should aim to remain backwards compatible. Perhaps master should stay sync'd with Rails edge, and we could create branches for major Rails releases and let the community backport ActiveScaffold features as needed. Consider http://www.loudthinking.com/posts/20-dont-overestimate-the-power-of-versions. Nov 03, 2008 activescaffold issue 316 (support 'select' in field_search, similar to 'New' & 'Edit') Status changed - 111a23f6bc Status: Fixed 111a23f6bc Status: Fixed Nov 03, 2008 activescaffold issue 516 (Field override not working for show action.) Status changed - b844b09cc Status: Fixed b844b09cc Status: Fixed Nov 03, 2008 activescaffold issue 526 (helper loading in enviroment.rb) Status changed - the best solution is to use rails' autoloading by organizing the directories to match module and class names. anyone can submit a patch. Status: New the best solution is to use rails' autoloading by organizing the directories to match module and class names. anyone can submit a patch. Status: New Nov 02, 2008 activescaffold issue 284 ([PATCH] adding associated objects for polymorphic relations) Status changed - Status: Fixed Status: Fixed Nov 02, 2008 activescaffold issue 355 (Singular association autolinking should check for existance ...) Status changed - Status: Fixed Status: Fixed Oct 31, 2008 activescaffold issue 340 (Polymorphic models not expanded properly in association subf...) Status changed - Status: AlreadyFixed Status: AlreadyFixed Oct 31, 2008 activescaffold issue 534 (Infinite loop with Internet Explorer when sorting) Status changed - Status: Fixed Status: Fixed Oct 31, 2008 activescaffold issue 624 (alias_method_chain methods do not take blocks) commented on - Perhaps we should link to a couple of guides from the Pull Requests wiki page? Perhaps we should link to a couple of guides from the Pull Requests wiki page? Oct 30, 2008 activescaffold issue 382 (removing last association in a subform) Status changed - d3e67ce8044ac64febb3127294c700d8e05ea941 Status: Fixed d3e67ce8044ac64febb3127294c700d8e05ea941 Status: Fixed Oct 30, 2008 activescaffold issue 404 (validation doesn't put red border on single association sele...) Status changed - 0ef10210eee7918fdb2f941dfaee02caf97284e9 Status: Fixed 0ef10210eee7918fdb2f941dfaee02caf97284e9 Status: Fixed Oct 30, 2008 activescaffold issue 563 (Issue deleting when nested rows shown) Status changed - a5bbceafd93600a86369580b38d6fdbb9ebc0b6e Status: Fixed a5bbceafd93600a86369580b38d6fdbb9ebc0b6e Status: Fixed Oct 30, 2008 activescaffold issue 312 (default list display for plural associations) Status changed - f4522dd1f435db36391db675c477ea050eb2dc15 Status: Fixed f4522dd1f435db36391db675c477ea050eb2dc15 Status: Fixed Oct 30, 2008 activescaffold issue 405 (Default association formatting has hard coded values) Status changed - 01a6b3f4e5cfc8353ff170736bcd7be130af97b7 Status: Fixed 01a6b3f4e5cfc8353ff170736bcd7be130af97b7 Status: Fixed Oct 30, 2008 activescaffold issue 551 (Date types do not save in a nested table) commented on - I'm guessing this is a problem with subforms, not nested tables. I'm guessing that this is only a problem when the subform displays only dates. The problem is that ActiveScaffold tries to determine if a posted parameter hash is "empty" or not, and since date inputs may have default values they are ignored. So a parameters hash that only contains date fields will be considered "empty". I'm guessing this is a problem with subforms, not nested tables. I'm guessing that this is only a problem when the subform displays only dates. The problem is that ActiveScaffold tries to determine if a posted parameter hash is "empty" or not, and since date inputs may have default values they are ignored. So a parameters hash that only contains date fields will be considered "empty".

issue 62 (RecordSelect returns incorrect results when used with Rails ...) commented on - So the problem is that when ActiveScaffold sets up RS, the params are something like {:controller => 'contacts', :action => 'new', :id => 15}. So AS stuffs all of those into options[:params]. Which is wrong. The options[:params] hash is supposed to be for extra parameters in the RS url, like "?role=Admin" to restrict results via the record_select_conditions_from_params() controller helper. But since ActiveScaffold is actually passing through all current params, including the :id, then RS ends up with an incorrect url. url = url_for(options[:params].merge(...)) is supposed to mean: url = url_for({:role => 'Admin'}.merge(:action => 'browse', :controller => 'locations')) but instead ends up meaning: url = url_for({:controller => 'contacts', :action => 'new', :id => 15}.merge(:action => 'browse', :controller => 'locations')) And that's just not going to work. ActiveScaffold should not be passing current request parameters to the RecordSelect helper.

So the problem is that when ActiveScaffold sets up RS, the params are something like {:controller => 'contacts', :action => 'new', :id => 15}. So AS stuffs all of those into options[:params]. Which is wrong. The options[:params] hash is supposed to be for extra parameters in the RS url, like "?role=Admin" to restrict results via the record_select_conditions_from_params() controller helper. But since ActiveScaffold is actually passing through all current params, including the :id, then RS ends up with an incorrect url. url = url_for(options[:params].merge(...)) is supposed to mean: url = url_for({:role => 'Admin'}.merge(:action => 'browse', :controller => 'locations')) but instead ends up meaning: url = url_for({:controller => 'contacts', :action => 'new', :id => 15}.merge(:action => 'browse', :controller => 'locations')) And that's just not going to work. ActiveScaffold should not be passing current request parameters to the RecordSelect helper.

Earlier this year

Older