Simplified some code #596
Merged
Simplified some code #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug #593 was misleadingly reported as pertaining to another project, but testing revealed it affected this project as well. The Code128 encoding algorithm failed when an odd number of digits were followed by FNC1 and other digits. The code selection algorithm was rewritten. A test case showing the bug was added, and an old test case was updated to expect the result of the new algorithm - another valid encoding of the same length as the old one.
Bug #593 was misleadingly reported as pertaining to another project, but testing revealed it affected this project as well. The Code128 encoding algorithm failed when an odd number of digits were followed by FNC1 and other digits. The code selection algorithm was rewritten. A test case showing the bug was added, and an old test case was updated to expect the result of the new algorithm - another valid encoding of the same length as the old one.
Removed imports I didn't use after all.
Added a private enum and changed some names to improve readability. Also some trivial cosmetic changes.
Removed a private one-liner method used exactly once, alphabetized imports.
Removed testing every pixel for greyness in RGBLuminanceSource, as it did not appreciably change the speed of converting a greyscale image and slowed down the conversion of a colour image by a few percent. Besides, there was no need to treat every row separately; the total number of pixels was enough.
Simplified some code, added more accurate error checking, and corrected small inaccuracies in comments.
| } | ||
| } | ||
| // Ones from firstBit to lastBit, inclusive | ||
| int mask = (2 << lastBit) - (1 << firstBit); |
There was a problem hiding this comment.
That's pretty cool, never though of writing it this way. Seems to work. You can inline this in the line below if you like.
There was a problem hiding this comment.
Right, that makes sense. Done.
|
Yeah looks like nice optimizations, well done. I'll merge it when I get back. |
|
Thanks. I like that kind of stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified a few bits of code in BitArray and RGBLuminanceSource, improving performance at least marginally.