Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strings.xml #276

Merged
merged 1 commit into from Dec 28, 2014
Merged

Update strings.xml #276

merged 1 commit into from Dec 28, 2014

Conversation

eliovir
Copy link
Contributor

@eliovir eliovir commented Dec 28, 2014

Typo (unbreakable spaces before ":")

@eliovir
Update strings.xml
c4f5e7e 
Typo (unbreakable spaces before ":")
@srowen
Copy link
Contributor

srowen commented Dec 28, 2014

Hm OK. How about just a regular space or no space in these cases?

@eliovir
Copy link
Contributor Author

eliovir commented Dec 28, 2014

For French typo, a space must appear before the 2-sign punctuations (:;!?). But such sign could be detached if it is a simple space. Thanks for the changes.

srowen added a commit that referenced this pull request Dec 28, 2014
@srowen
Merge pull request #276 from eliovir/patch-1
c676bdb 
Update strings.xml
@srowen srowen merged commit c676bdb into zxing:master Dec 28, 2014
@eliovir eliovir deleted the patch-1 branch December 28, 2014 21:53
@srowen srowen self-assigned this Feb 12, 2015
@srowen srowen modified the milestone: 3.2.0 Feb 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@srowen srowen

Labels
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliovir @srowen