xdelta3.c:6053: warning: passing argument 3 of fprintf_chk makes pointer from integer
without a cast

gcc (GCC) 4.1.0 on SUSE Linux

Almost always (except once or twice out of 1000s) the warnings about signed/unsigned
and type-punned pointers are harmless. I haven't carefully looked at the 1.1.x warnings.

It seems that with every new platform, gcc4 gives new and interesting warnings.  With
3.x, I left one warning in, repeated three times, about a potential
non-initialization of "match_offset". This one is definitely safe.

I would think so, too. But after ~100 "warnings" the final error kills the setup script:

error: command 'gcc' failed with exit status 1

This is a standard Suse10 install. Nothing special, and no way to downgrade to gcc3
at the moment...

1.1.4 builds for me on Gentoo w/ gcc-4.1.1, despite warnings.  1.1.x has a setup script.

3.x builds w/o warnings on gcc-4.1.1. Your report confused me because it was a
warning for a 3.x file (xdelta3.c). 3.x doesn't have a setup script (at least not
written by me). Can you include the full output?

MS VC++ builds 3.x with a bunch of warnings.

>Note that xdelta3 sources are warning-free on gcc4.

I'm getting loads of warnings on gcc4... most of them in relationship with xoff_t,
but most of them look harmless... If your interested, I'll be happy to send you the
make output...

What platform are your errors on?  At least on my Gentoo Linux box, gcc-4.1.1 is
relatively quiet. Feel free to send them to me. 

I can't compile xdelta3 at all on 4.02 gcc.  It borks on the P macro.  The macro
tricks in xdelta 3 code look pretty unportable IMO.

P is not a big problem. I'll fix it.

I changed P -> DP in SVN 153

3.0q fixes the P problem

confirmed q version fixed compile in gcc 4.02...thx!
couple other things I noticed:

* stdin/stdout appear not to work in the windows executable.  Not serious at all, but
I have to give all filenames as arguments.  I get this error (or same for stdout if
-s is supplied):
xdelta3: input read failed: (stdin): The handle is invalid.

* xdelta3 windows has dependency on the  msvc 8.0 runtime.  This isn't indicated on
your site, and might trip up some people.  I would suggest providing a static
compiled version or making a note of the dependency on the web page at least.

great little program.  I am testing xdelta and am finding the new version to provide
much better worst case performance than the older, supposedly faster version.  It is
much better on memory usage too...the older version basically broke down when the
input file was bigger than ram.

merlin

I posted two .msi files for 3.0q, the first (xdelta30q.msi) was a mistake (not
static), the second (xdelta3q.1.msi) was static. Others have confirmed. Can you try
xdelta3q.1.msi? You will not need the msvc 8.0 runtime. Thanks.

P.S. I have almost no MS VC++ experience, so anyone reporting issues who knows what
they are talking about, please include instructions on how to fix the problem if you
can. Thanks.

Would you show me using xdelta3 in VC++? 
It will be thankful for xdelta3 dll or lib.

gcc 4.3 trunk shows the following warnings with latest SVN:

In file included from xdelta3.c:777:
xdelta3-main.h: In function 'main_recode_func':
xdelta3-main.h:1451: warning: pointer targets in passing argument 1 of 'strlen'
differ in signedness
In file included from xdelta3.c:781:
xdelta3-test.h: In function 'test_forward_match':
xdelta3-test.h:586: warning: pointer targets in passing argument 1 of
'xd3_forward_match' differ in signedness
xdelta3-test.h:586: warning: pointer targets in passing argument 2 of
'xd3_forward_match' differ in signedness
xdelta3-test.h:592: warning: pointer targets in passing argument 1 of
'xd3_forward_match' differ in signedness
xdelta3-test.h:592: warning: pointer targets in passing argument 2 of
'xd3_forward_match' differ in signedness
xdelta3-test.h: In function 'test_compress_text':
xdelta3-test.h:761: warning: pointer targets in passing argument 1 of 'strlen' differ
in signedness
xdelta3-test.h: In function 'test_decompress_text':
xdelta3-test.h:833: warning: pointer targets in passing argument 1 of 'strlen' differ
in signedness
xdelta3-test.h:834: warning: pointer targets in passing argument 1 of 'strlen' differ
in signedness

(No comment was entered for this change.)

The 3.x warnings have been fixed.