Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFRAME replacement #257

Open
GoogleCodeExporter opened this issue Apr 4, 2015 · 8 comments
Open

IFRAME replacement #257

GoogleCodeExporter opened this issue Apr 4, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

WP 2.8.4, GM 1.3a (1.26 on other site)

Suggestion:
Replace IFRAME to DIV in map uotput.

Original issue reported on code.google.com by urso...@gmail.com on 12 Sep 2009 at 6:53

@GoogleCodeExporter
Copy link
Author

I wish I had an earlier discussion with Jan Wildefeld about this here, but the
summary for me is that I need to change the IFRAME tag eventually to create 
valid
XHTML 1.0 Strict code.

It will be a big job, and we'll lose some nice benefits of the IFRAME, which 
allows
Geo Mashup to collect all the resources needed to create a map in a separate 
space
from the WordPress page, which often contains CSS and JavaScript code that 
adversely
affects a Google map. It also prevents the overhead of loading all of those Geo
Mashup resources on WordPress pages that don't contain maps.

Original comment by dylankk...@gmail.com on 14 Sep 2009 at 11:49

  • Changed state: Accepted
  • Added labels: Type-Enhancement

@GoogleCodeExporter
Copy link
Author

Was any progress made with this?

Original comment by co...@rainsforth.co.uk on 10 Nov 2014 at 6:22

@GoogleCodeExporter
Copy link
Author

It seems no one has needed it enough to head up development yet. My own 
experience has been that iframes are well supported in current browsers and not 
causing serious problems. I'd still like to at least have the option to get rid 
of them, but I'm not convinced that there's enough developer support for Geo 
Mashup to get it done right.

Original comment by dylankk...@gmail.com on 10 Nov 2014 at 6:54

@sunylyons
Copy link

Has anyone come up with a method for displaying maps that doesn't involve iframes? Perhaps if we could use file_get_contents or CURL somehow as a kludge? For example, I wish this sort of thing would work with Geo Mashup:

...but sadly it just returns "WordPress transients may not be working. Try deactivating or reconfiguring caching plugins. issue 425". However I'm not doing any caching.

In my case something like this would be great because I'm using WP JSON API to pull data into my AngularJS / Ionic app. I'm using posts to display all sorts of data in lists and views, and then using maps of posts with geolocation to allow users to explore the data geographically, since the data relates to events happening around them in real time as they use the app.

Geo Mashup cooperates pretty well as-is, however because the maps are in iframes there are several levels of interaction with the app that I'm unable to accomplish. Any working method to display the maps without iframes would be amazing, no matter how dirty!

@cyberhobo
Copy link
Owner

@sunylyons you should be able to bypass the transient lookup by removing the map_data_key parameter.

@titaniumbones
Copy link

@sunylyons did you ever get this working? I have an issue which is quite a bit simpler that still makes it tough to use geo mashup. I am creating an image overlay layer out of a historical map. I would like to add a slider that adjusts the opacity of htat layer, but I can't get access to the relevant variable from the parent frame context. Maybe there's a solution already?

@cyberhobo
Copy link
Owner

@titaniumbones you can see here how geo mashup renders a widget like a term legend in the parent frame:

https://github.com/cyberhobo/wordpress-geo-mashup/blob/master/js/taxonomy.js#L61

@titaniumbones
Copy link

Thank you @cyberhobo. It's a little beyond me but I'm getting close to undertanding what's going on.
I have more questions but I'll put them in another thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants