My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips
Issue 190: @ autocomplete not functioning correctly
3 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  jongallo...@gmail.com
Closed:  Feb 2009


Sign in to add a comment
 
Reported by johnshee...@gmail.com, Jan 19, 2009
What steps will reproduce the problem?
1. Launch latest experimental
2. Type @ in a new tweet

What is the expected output? What do you see instead?
Typing @ results in $1 followed by the twitter name of the first user 
alphabetically. The keyboard shortcuts (tab, up, down) to select the user 
don't work. Typing another letter does not continue the autocomplete.

What version of the product are you using? On what operating system?
Experimental, Vista x64
2009-01-19_1332.png
17.7 KB   View   Download
Comment 1 by johnshee...@gmail.com, Jan 19, 2009
The attached screengrab doesn't show that the text immediately following $1 is 
highlighted.
Comment 2 by johnshee...@gmail.com, Jan 27, 2009
If you follow someone who's twitter name starts with a number (like @37Signals), it 
breaks the autocomplete. It also crashes witty if you follow a user like this and 
type @ somewhere other than the first character in the box

see http://www.screencast.com/users/JohnSheehan/folders/Jing/media/3dc81c57-f0da-
4cc6-a4e7-19bbd718ff36
Comment 3 by ross.mas...@gmail.com, Jan 30, 2009
This is also occurring for me, except I'm not using the experimental version 
(2.1.0.540). I often get $137signals when trying to @ someone. Will try unfollowing 
37signals (and any other numerical ones) to check.
Comment 4 by cbrol...@gmail.com, Jan 30, 2009
I'm not a regex wizard, so I'm sure there is a more elegant way to fix this.  Here is
a patch to fix this issue for now.
autocomplete_190.patch
770 bytes   View   Download
Comment 5 by kris.sc...@gmail.com, Jan 30, 2009
correct me if I'm wrong but won't that patch replace all spaces in the text box so if 
I had typed "Hey check out this tweet by @blehbleh" it would change that to 
"Heychecloutthistweetby@blehbleh" ???
Comment 6 by kris.sc...@gmail.com, Jan 30, 2009
I believe by escaping the $1 with ${1} (which inside a string.Format must be ${{1}}) 
it will solve the problem.  Patch attached.
issue190fix.patch
720 bytes   View   Download
Comment 7 by cbrol...@gmail.com, Jan 30, 2009
@kris.scott Yeah, if there is text before the @<name> it would remove the spaces,
didn't see that, late night.  I'll fix it, thanks!
Comment 8 by cbrol...@gmail.com, Jan 30, 2009
@kris.scott Just saw your post, cool patch.
Comment 9 by project member jongallo...@gmail.com, Feb 2, 2009
Applied patch. Thanks for catching and fixing this, guys!
Status: Fixed
Owner: jongalloway
Sign in to add a comment

Powered by Google Project Hosting