issue 11943
(Replace sigslot with something leaner and mea)
commented on
by Git Watcher
-
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/4fc23457aa187e47373ca7abd69da782c985a360
commit 4fc23457aa187e47373ca7abd69da782c985a360
Author: Harald Alvestrand <hta@webrtc.org>
Date: Tue Apr 23 14:47:21 2024
Remove IceTransportInternal::SignalGatheringState
Landing when last remaining usage in Chrome has been removed.
Bug: webrtc:11943
Change-Id: I62817e2cc0b67113126b82424b6f843c77e66f31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341001
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42157}
[modify] https://crrev.com/4fc23457aa187e47373ca7abd69da782c985a360/p2p/base/ice_transport_internal.cc
[modify] https://crrev.com/4fc23457aa187e47373ca7abd69da782c985a360/p2p/base/ice_transport_internal.h
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/4fc23457aa187e47373ca7abd69da782c985a360
commit 4fc23457aa187e47373ca7abd69da782c985a360
Author: Harald Alvestrand <hta@webrtc.org>
Date: Tue Apr 23 14:47:21 2024
Remove IceTransportInternal::SignalGatheringState
Landing when last remaining usage in Chrome has been removed.
Bug: webrtc:11943
Change-Id: I62817e2cc0b67113126b82424b6f843c77e66f31
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/341001
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42157}
[modify] https://crrev.com/4fc23457aa187e47373ca7abd69da782c985a360/p2p/base/ice_transport_internal.cc
[modify] https://crrev.com/4fc23457aa187e47373ca7abd69da782c985a360/p2p/base/ice_transport_internal.h
20 hours ago
issue 12529
(Add RTCRemoteOutboundRtpStreamStats)
Status changed
by phan...@meta.com
-
RRTR seems to be missing for video so roundTripTimeMeasurements and totalRoundTripTime will stay 0 even when it is negotiated, e.g. on
https://jsfiddle.net/fippo/es41rL9g/2/
From what I can see there is no DLRR block sent for video.
Marking this as done, RRTR can be handled in a separate issue
Status: Fixed
RRTR seems to be missing for video so roundTripTimeMeasurements and totalRoundTripTime will stay 0 even when it is negotiated, e.g. on
https://jsfiddle.net/fippo/es41rL9g/2/
From what I can see there is no DLRR block sent for video.
Marking this as done, RRTR can be handled in a separate issue
Status: Fixed
22 hours ago
issue 11943
(Replace sigslot with something leaner and mea)
commented on
by Git Watcher
-
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5a7e7af829f621b60ebe8dcd5ddec8f530c90395
commit 5a7e7af829f621b60ebe8dcd5ddec8f530c90395
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Apr 23 14:33:29 2024
IceTransportInternal::GatheringState - use callback
This removes one sigslot usage.
Bug: webrtc:11943
Change-Id: I404ba56d1291af5dfaf2d8b9461ff3f7ce82d4bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318498
Reviewed-by: Tomas Gunnarsson <tommi@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291258}
[modify] https://crrev.com/5a7e7af829f621b60ebe8dcd5ddec8f530c90395/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5a7e7af829f621b60ebe8dcd5ddec8f530c90395
commit 5a7e7af829f621b60ebe8dcd5ddec8f530c90395
Author: Harald Alvestrand <hta@chromium.org>
Date: Tue Apr 23 14:33:29 2024
IceTransportInternal::GatheringState - use callback
This removes one sigslot usage.
Bug: webrtc:11943
Change-Id: I404ba56d1291af5dfaf2d8b9461ff3f7ce82d4bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5318498
Reviewed-by: Tomas Gunnarsson <tommi@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1291258}
[modify] https://crrev.com/5a7e7af829f621b60ebe8dcd5ddec8f530c90395/third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_adapter_impl.cc
Yesterday
24 hours ago
issue 15788
(Use absl::optional in api/rtp_headers.h for e)
commented on
by Git Watcher
-
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/54dec3f3d7c892e92a9675cb0315ac150ff76543
commit 54dec3f3d7c892e92a9675cb0315ac150ff76543
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Tue Apr 02 15:20:26 2024
Delete deprecated variants for parsing/building AudioLevelExtension
Bug: webrtc:15788
Change-Id: I37034b9b1daf7b26dd5e66156e71c63e2fb85b21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345520
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42152}
[modify] https://crrev.com/54dec3f3d7c892e92a9675cb0315ac150ff76543/modules/rtp_rtcp/source/rtp_header_extensions.cc
[modify] https://crrev.com/54dec3f3d7c892e92a9675cb0315ac150ff76543/modules/rtp_rtcp/source/rtp_header_extensions.h
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/54dec3f3d7c892e92a9675cb0315ac150ff76543
commit 54dec3f3d7c892e92a9675cb0315ac150ff76543
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Tue Apr 02 15:20:26 2024
Delete deprecated variants for parsing/building AudioLevelExtension
Bug: webrtc:15788
Change-Id: I37034b9b1daf7b26dd5e66156e71c63e2fb85b21
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/345520
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Åsa Persson <asapersson@webrtc.org>
Reviewed-by: Åsa Persson <asapersson@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42152}
[modify] https://crrev.com/54dec3f3d7c892e92a9675cb0315ac150ff76543/modules/rtp_rtcp/source/rtp_header_extensions.cc
[modify] https://crrev.com/54dec3f3d7c892e92a9675cb0315ac150ff76543/modules/rtp_rtcp/source/rtp_header_extensions.h
24 hours ago
issue 15870
(Build errors on GCC w/ libstdc++ 13.2.1 missi)
commented on
by Git Watcher
-
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/454d65196eccae44a9a64f3d02b26966edff9cba
commit 454d65196eccae44a9a64f3d02b26966edff9cba
Author: Vinzenz Feenstra <evilissimo@gmail.com>
Date: Wed Mar 13 23:54:32 2024
Fix build errors on GCC w/ libstdc++ 13.2.1 missing cstdint
Bug: webrtc:15870
Change-Id: Id91f6d603c777312eda6d3bc9f03c78109737372
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343000
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42150}
[modify] https://crrev.com/454d65196eccae44a9a64f3d02b26966edff9cba/AUTHORS
[modify] https://crrev.com/454d65196eccae44a9a64f3d02b26966edff9cba/test/rtp_file_reader.h
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/454d65196eccae44a9a64f3d02b26966edff9cba
commit 454d65196eccae44a9a64f3d02b26966edff9cba
Author: Vinzenz Feenstra <evilissimo@gmail.com>
Date: Wed Mar 13 23:54:32 2024
Fix build errors on GCC w/ libstdc++ 13.2.1 missing cstdint
Bug: webrtc:15870
Change-Id: Id91f6d603c777312eda6d3bc9f03c78109737372
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/343000
Reviewed-by: Jeremy Leconte <jleconte@webrtc.org>
Commit-Queue: Jeremy Leconte <jleconte@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42150}
[modify] https://crrev.com/454d65196eccae44a9a64f3d02b26966edff9cba/AUTHORS
[modify] https://crrev.com/454d65196eccae44a9a64f3d02b26966edff9cba/test/rtp_file_reader.h
issue 15929
(Custom Codec Negotiaton - C++ interface)
reported
by hta@webrtc.org
- Feature description (please include a link to the functional spec):
Tracking the implementation of a C++ interface that allows the Custom Codec Negotiation to be implemented in Chrome.
Spec: https://github.com/w3c/webrtc-encoded-transform/pull/186
Feature description (please include a link to the functional spec):
Tracking the implementation of a C++ interface that allows the Custom Codec Negotiation to be implemented in Chrome.
Spec: https://github.com/w3c/webrtc-encoded-transform/pull/186
issue 15917
(Perfetto Support)
commented on
by Git Watcher
-
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/5bfcc873d922e9075798f29141c99c0f6ae3501e
commit 5bfcc873d922e9075798f29141c99c0f6ae3501e
Author: Evan Shrubsole <eshr@google.com>
Date: Tue Apr 23 08:51:23 2024
Add event scope to all TRACE_EVENT_INSTANTs
These are required by the Perfetto API and the missing argument prevents
the use of Perfetto.
Bug: webrtc:15917
Change-Id: Ie40c0344dc9d8cd40f7c751b133d150b975a33c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347702
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/main@{#42147}
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/video_stream_encoder.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/modules/video_coding/generic_decoder.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/rtc_base/trace_event.h
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/rtc_base/event_tracer.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/video_send_stream_impl.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/pc/rtc_stats_collector.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/modules/desktop_capture/mac/screen_capturer_mac.mm
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/frame_cadence_adapter.cc
The following revision refers to this bug:
https://webrtc.googlesource.com/src/+/5bfcc873d922e9075798f29141c99c0f6ae3501e
commit 5bfcc873d922e9075798f29141c99c0f6ae3501e
Author: Evan Shrubsole <eshr@google.com>
Date: Tue Apr 23 08:51:23 2024
Add event scope to all TRACE_EVENT_INSTANTs
These are required by the Perfetto API and the missing argument prevents
the use of Perfetto.
Bug: webrtc:15917
Change-Id: Ie40c0344dc9d8cd40f7c751b133d150b975a33c7
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/347702
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org>
Commit-Queue: Evan Shrubsole <eshr@google.com>
Cr-Commit-Position: refs/heads/main@{#42147}
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/video_stream_encoder.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/modules/video_coding/generic_decoder.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/rtc_base/trace_event.h
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/rtc_base/event_tracer.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/video_send_stream_impl.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/pc/rtc_stats_collector.cc
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/modules/desktop_capture/mac/screen_capturer_mac.mm
[modify] https://crrev.com/5bfcc873d922e9075798f29141c99c0f6ae3501e/video/frame_cadence_adapter.cc