New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinction between Vimperator and Muttator #617
Comments
Yeah, that's a very interesting question. I personally haven't used If Vimperator was rewritten as an WebExtension, then I think it's quite Martin On Fri, Oct 14, 2016 at 8:42 PM, SammysHP notifications@github.com wrote:
|
Please don't abandon muttator :-) I only wish it had proper Vim integration. I was wondering if that might even be feasible now with neovim... On 16 October 2016 18:15:21 BST, Martin Stubenschrott notifications@github.com wrote:
|
@maxauthority Make new muttator release please. |
Yeah, sounds like a good idea. I'll also give @gkatsev owner rights on addons.mozilla.org so he can also make releases as he likes :) I just need to first find out, how to login to addons.mozilla.org first, as my usual username/password combo doesn't work anymore but it asks for a "Firefox account" with an email address (and mine isn't found). Has anybody had the same issue and do I really need to create (and associate) a new Firefox account? |
I got a mail some weeks ago to migrate my account. Here's a help article: https://support.mozilla.org/en-US/kb/access-your-add-ons-firefox-accounts |
Oh, must have missed that! Thanks a lot! Will do it tomorrow or so, and then add (at least) @gkatsev to the "people with power" on AMo for Muttator, so future updates should be much more reliable if it is not depending on a single person. |
Ok, I tried releasing Muttator 1.4, but it didn't pass the review :( They seem to get more strict about the usage of eval. Wondering though, why Vimperator 3.15 was accepted with the same usage. Maybe we just had "bad luck", but still not sure, how to continue best:Hello, Your add-on, Muttator 1.4, has been reviewed and did not meet the criteria for being hosted in our gallery. Reviewer: Comments:
This version of your add-on has been disabled. You may re-request review by addressing the reviewer's comments and uploading a new version at https://addons.mozilla.org/en-US/developers/addon/muttator/versions If you want to respond to this review, or have any questions about it, please reply to this email or join #amo-editors on irc.mozilla.org. To learn more about the review process, please visit https://developer.mozilla.org/en-US/Add-ons/AMO/Policy/ReviewsMozilla Add-ons Team |
I just wanted to implement a new feature that is Firefox-only and wondered where I should start. Most code is in
common/content
which is shared between Vimperator and Muttator.Actually lots of code in
common
is not meant for Thunderbird/Muttator. Even worse: There are version checks in it that compare the version number (e.g. common/content/sanitizer.js#L111) without any distinction between Firefox and Thunderbird.What should we do? Firefox and Thunderbird divert even more with time. I wonder if Vimperator can exist in the future (e.g. multi process) while keep sharing code with Thunderbird.
The text was updated successfully, but these errors were encountered: