Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Vimperator syntax highlighting to seperate repo #463

Merged
merged 2 commits into from Apr 26, 2016

Conversation

timss
Copy link
Member

@timss timss commented Mar 19, 2016

Main motivation is to make it easier to install, especially with popular Vim plugin managers such as Vundle or Pathogen.

https://github.com/vimperator/vimperator.vim – Full commit history is included.

@timss
Copy link
Member Author

timss commented Apr 22, 2016

Hm, why is this still "in progress", @gkatsev ?

@maxauthority
Copy link
Member

I just looked at this as well. I think both approaches (keeping vimperator.vim in this repo, or in a separate) have both advantages.

But isn't a VimBall (.vba) the "official" vimscript distribution format? It seem this isn't supported anymore in the new Repo.

However, since I am not the main target user, maybe we have some more opinion about the issue how we handle the vimperator.vim scripts in future?

@gkatsev
Copy link
Member

gkatsev commented Apr 22, 2016

not quite sure what it's "in progress" and vimballs aren't really official and they're a pain and no one likes them, really. Most people just use a git repo or just a folder with a set structure that things like pathogen can load.

@timss
Copy link
Member Author

timss commented Apr 22, 2016

I'm not sure if many people know that vimperator syntax highlighting is included in the current repo because it's rather hidden. I haven't seen it referenced much at all, and yeah, vimballs are a pain.

Second to being easier to install, splitting it to a seperate repo might also help make people aware of it.

If you think it should be merged in the current state, I'll look into fixing the branch conflicts. Any +1s? :-)

@timss
Copy link
Member Author

timss commented Apr 26, 2016

Looks like I was able to successfully fix my diverging/conflicting branch without messing up, yay.

Merging.

@timss timss merged commit 9599dc9 into vimperator:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants