Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimperator can't gain focus against Google #14

Closed
MPW1412 opened this issue Jul 22, 2014 · 23 comments
Closed

Vimperator can't gain focus against Google #14

MPW1412 opened this issue Jul 22, 2014 · 23 comments

Comments

@MPW1412
Copy link

MPW1412 commented Jul 22, 2014

Hello,

I love the vimperator plugin. But I can't use it on any google page. Google grabs the focus to its search field.

After pressing ESC and then pressing any key, the focus returns to the google text field and the char is inserted there.

Firefox 30.0, Ubuntu 12.04 64bit.

Thanks for reading
MPW

@oysteinkrog
Copy link

I get this too, it's really annoying:p

@maxauthority
Copy link
Member

Also pressing Esc to clear the search box dose not work? (Maybe you meant
that, but the Esc was eaten as a HTML tag).

Alternatively, try :set focuscontent

On Sat, Jul 26, 2014 at 8:17 PM, Øystein Krog notifications@github.com
wrote:

I get this too, it's really annoying:p


Reply to this email directly or view it on GitHub
#14 (comment)
.

@MPW1412
Copy link
Author

MPW1412 commented Jul 28, 2014

Hello,

thanks for your comment. With focuscontent it works, but I have to manually set to focus to any text field now. That's a step backwords.

In standard configuration you can't set the focus to the vimperator at all. Not with pressing ESC 10 times or more. Any char is captured by google.

@MPW1412
Copy link
Author

MPW1412 commented Jul 28, 2014

I think I'm getting closer. Try this out:

  • Go to http://www.google.de (probably other countries work the same way, didn't tested that).
  • set the focus to the search field, with the mouse, or with the command 'gi' or any other way

For me, there's no way out of that textfield without using the mouse now. No command reaches the vimperator anymore.

@maxauthority
Copy link
Member

I can reproduce the issue. Which is good as it's reproducible, but bad
because big sites like google should always work as expected.

On Mon, Jul 28, 2014 at 6:53 PM, MPW1412 notifications@github.com wrote:

I think I'm getting closer. Try this out:

  • Go to http://www.google.de (probably other countries work the same
    way, didn't tested that).
  • set the focus to the search field, with the mouse, or with the
    command 'gi' or any other way

For me, there's no way out of that textfield without using the mouse now.
No command reaches the vimperator anymore.


Reply to this email directly or view it on GitHub
#14 (comment)
.

@MPW1412
Copy link
Author

MPW1412 commented Jul 28, 2014

You just have to find a way, to pass the ESC-key through the google java script code to vimperator.

There's another problem which may be related to this one. Sometimes on other pages the ESC key doesn't work either. You have to open a new tab or do something else with the mouse to get the focus back to vimperator.

All this seems to be related to the no the "nosetfocuscontent" setting. When I switch to "nosetfocuscontent" this bug starts to occur and I get cought in some textfields. With "setfocuscontent" everything works perfectly.

This field in github right here is another trap. With nosetfocuscontent I sometimes get trapped here, too.

@zzt93
Copy link

zzt93 commented Oct 13, 2014

It works fine for me. Ubuntu14.04 firefox 32.03

@MPW1412
Copy link
Author

MPW1412 commented Nov 2, 2014

It seems to work on Windows, but it DOES NOT in Ubuntu 14.04 with Firefox.

So this seems to be a linux related bug.

@Koward
Copy link

Koward commented May 23, 2015

I confirm this is still not solved as today 23 may 2015 on Ubuntu. You have to use the mouse as soon as you open your browser if your front page is Google. You can still reproduce it the same way MPW1412 did.

@MPW1412
Copy link
Author

MPW1412 commented May 23, 2015

The curious thing is, on two pcs with Ubuntu it works perfectly. I can't find any difference in the configuration.

Is there a way to dump the configuration and compare it?

@Koward
Copy link

Koward commented May 23, 2015

For the whole configuration of Ubuntu, I don't think so, but parts of it probably.
Concerning Vimperator itself, I was able to fix this by adding an autocmd and setting focuscontent in my .vimperatorrc, but it's not working using the stock settings.
Maybe could you try without any personal change ?

EDIT : It works on Windows, though, so, imo, it's still a linux problem.

@maxauthority
Copy link
Member

I recently noticed that pressing Esc and : also does not open the command
line when google.com is open. This will be quite serious, but probably has
something to do which keys (keydown/keypress/etc.) we handle. By fixing one
site we seem to "unfix" another :(

On Sat, May 23, 2015 at 4:16 PM, Koward notifications@github.com wrote:

For the whole configuration of Ubuntu, I don't think so, but parts of it
probably.
Concerning Vimperator itself, I was able to fix this by adding an autocmd
and setting focuscontent in my .vimperatorrc, but it's not working using
the stock settings.
Maybe could you try without any personal change ?


Reply to this email directly or view it on GitHub
#14 (comment)
.

@MPW1412
Copy link
Author

MPW1412 commented Jun 9, 2015

I recently noticed, that it occurs much less often, if you activate the vi status bar. Which is unfortunatly not hidden, if you watch html5 videos on fullscreen. But for standard mode, this is a nice workaround.

And Ctrl + Alt Gr + 8 (german Keyboard for [) works much better to escape, than button escape.

@pelegm
Copy link

pelegm commented Jul 29, 2015

I confirm the bug on Ubuntu 14.04.2 with Vimperator 3.9. I also confirm that Ctrl-[ works perfectly.

This bug kills many of my mappings. For example, this one:

map sgo Y:tabopen<Space>google<Space><S-Insert><Return>

I know this one can be achieved by P, but not if google is not my defsearch.

@Enzime
Copy link
Contributor

Enzime commented Sep 17, 2015

Have you tried building vimperator from GitHub master? There's a fix for this in one of the commits that aren't in a release yet, although the mouse clicking not allowing you to lose focus may mean it's something else.

@xerebz
Copy link

xerebz commented Nov 5, 2015

I'm pretty sure this is because some sites remap the escape key. Ctrl+[ works but keycode 27 (esc) is hijacked by some javascript.

@maxauthority
Copy link
Member

Yeah, git master should work. I guess I'll release a new vimperator version
soon!

On Thu, Nov 5, 2015 at 2:10 AM, Alain Leon notifications@github.com wrote:

I'm pretty sure this is because some sites remap the escape key. Ctrl+[
works but keycode 27 (esc) is hijacked by some javascript.


Reply to this email directly or view it on GitHub
#14 (comment)
.

@pjvds
Copy link

pjvds commented Nov 24, 2015

Great news! Looking forward to the new version 👍

@MPW1412
Copy link
Author

MPW1412 commented Nov 24, 2015

Thanks for your work! I still love the vimperator and use it on all my pcs. I'm looking forward to the new version!

@gkatsev gkatsev added the medium label Jan 27, 2016
@timss
Copy link
Member

timss commented May 6, 2016

A lot has changed since this was reported, and behavior can be a bit different on different platforms, desktops etc. Not able to reproduce with FF 45, Vimperator 3.13.0 without config and KWin (Linux), so closing for now.

Please shout out of you're still able to reproduce in latest release, and it'll be reopened or redirected to another/new issue. Thanks.

@timss timss closed this as completed May 6, 2016
@timss timss removed the medium label May 6, 2016
@oysteinkrog
Copy link

I can also no longer repro :)
FF 46, Win64, Vimperator 3.13.0.

@MPW1412
Copy link
Author

MPW1412 commented May 6, 2016

Seems to be fixed in 3.13.0.

@timss
Copy link
Member

timss commented May 6, 2016

Great, thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests