Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include icon in Windows context menu #249

Closed
GoogleCodeExporter opened this issue Aug 18, 2015 · 11 comments
Closed

Include icon in Windows context menu #249

GoogleCodeExporter opened this issue Aug 18, 2015 · 11 comments

Comments

@GoogleCodeExporter
Copy link

What version of the product are you using? On what operating system?
- GVim 7.4 (Aug 10, 2013)
- Windows 7, 64-bit

Please include the vim icon in the Windows context menu when right-clicking on 
a file to edit.  This would make it much easier to find the "Edit with Vim" 
entry, especially on context menus that have numerous other additional menus, 
many of which also already have icons.

Original issue reported on code.google.com by brian.ma...@betteradmin.com on 18 Aug 2014 at 9:00

@GoogleCodeExporter
Copy link
Author

I have a fix. But I couldn't test it. I had trouble setting up the build 
environment.
Can someone test it for me, please?

The fix is here: 
https://code.google.com/r/marioweber88-vim/source/detail?r=ed13ee673efda7fdacf0c
db53e98bd6b97b30ee5

Original comment by marioweb...@gmail.com on 7 Apr 2015 at 11:04

@GoogleCodeExporter
Copy link
Author

Thanks for stepping forward and making those changes. For building Vim with 
Windows, see this wiki entry: 
http://vim.wikia.com/wiki/Build_Vim_in_Windows_with_Visual_Studio

Note those changes need WINVER=0x0500 so you need to adjust the Makefile and 
have APPVER=5.0 then you can successfully build it.

I compiled it and installed it manually as described in the readme (e.g. copied 
the dll to c:\windows\system32, merged the reg file, changed the path in the 
registry to point to the actual gvim.exe binary and right clicked on a file. 
Unfortunately, there was no icon in the popup menu. 

So could you please have another look? Thanks.

Original comment by chrisbr...@googlemail.com on 8 Apr 2015 at 8:37

@GoogleCodeExporter
Copy link
Author

I'll look at it again.

I'm using Windows 8.1 64-bit and VS2013.

I couldn't build with the makefile at all. I got an error for a missing file.

So I created a new project in VS and copied the source files. I had to make 
some more changes, because the variable oldenv was not defined. I didn't commit 
those changes, because I thought this error was due to my build setup being 
wrong.

But using this I could compile and I saw the icons in the context menu. Only 
problem was an error message when I selected an entry. I think this was because 
of the oldenv problem I didn't use unicode when creating the process for vim.

Original comment by marioweb...@gmail.com on 9 Apr 2015 at 4:22

@GoogleCodeExporter
Copy link
Author

Think I fixed it =)

https://code.google.com/r/marioweber88-vim/source/detail?r=b3ed4ffac395f73e2e693
6a3b51be132f669ba14#

Works fine on my system.
Let me know if it works for you too.

Original comment by marioweb...@gmail.com on 9 Apr 2015 at 9:39

Attachments:

@GoogleCodeExporter
Copy link
Author

Works fine now. 

Only needed to change APPVER to 5.0 in Makefile, as described above, when 
compiled with MSVC compiler. And also add -lgdi32 to LIBS in Make_ming when 
compiled with MinGW (MinGW64 in my case).

Original comment by andrei.o...@gmail.com on 9 Apr 2015 at 11:58

@GoogleCodeExporter
Copy link
Author

fixed in 7.4.724

Original comment by chrisbr...@googlemail.com on 4 May 2015 at 4:57

  • Changed state: Fixed

@orev
Copy link

orev commented Sep 21, 2016

I just updated to 8.0 and this is not included with it. On Windows 7 64-bit.

@k-takata
Copy link
Member

It seems that gvimext.dll bundled with the official installer (gvim80.exe) is old. The build timestamp is 2008-08-10.
The nightly builds have newer gvimext.dll: https://github.com/vim/vim-win32-installer/releases

@orev
Copy link

orev commented May 26, 2017

As of the gvim80-586 installer, this is still not included. However it is included in the nightly build as of 8.0.0604.

It is also not included in the "Vim without Cream" build as of 8-0-568

@brammool
Copy link
Contributor

brammool commented May 27, 2017 via email

@orev
Copy link

orev commented May 30, 2017

I tested the 604 build on an XP machine, and it seems to work fine. However, the icon is a little off, but maybe that's just how XP works. See attached:

gvimext-604-winxp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants