Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile vim 7.4.238+ with Linux kernel version <= 2.6.36 due to addition of smack support. #217

Closed
GoogleCodeExporter opened this issue Aug 18, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Try to compile vim 7.4.238+ on a host with Linux kernel version < 2.6.36 
(e.g. RHEL 6.4, kernel 2.6.32)

What is the expected output? What do you see instead?

The smack configure check, added in patch 238 and enabled by default, checks 
for the 'llistxattr' symbol and the xattr.h header. The symbol and include both 
exist in Linux versions older than 2.6.36, which causes HAVE_SMACK to be set.

However, the smack code in os_unix.c makes use of XATTR_NAME_* defines that 
were introduced 2.6.36 
(http://lxr.free-electrons.com/source/include/linux/xattr.h?v=2.6.36). This 
causes the compile to fail.

What version of the product are you using? On what operating system?

Vim 7.4.238+, RHEL 6.4 Linux kernel version 2.6.32

Please provide any additional information below.

If possible, the configure check code should use the XATTR_NAME_* defines it 
uses in os_unix.c, such that the check fails when compiled against a kernel 
where those defs don't exist.

Original issue reported on code.google.com by coryom...@gmail.com on 8 Apr 2014 at 5:24

@GoogleCodeExporter
Copy link
Author

Sorry, issue topic should read kernel version < 2.6.32, not <= (it compiles 
fine on 2.6.36 as the XATTR_NAME_* defines are present).

Original comment by coryom...@gmail.com on 8 Apr 2014 at 5:26

@GoogleCodeExporter
Copy link
Author

Workaround for these platforms is to pass --disable-smack to configure.

Original comment by coryom...@gmail.com on 8 Apr 2014 at 5:28

@GoogleCodeExporter
Copy link
Author

Looks like this is fixed in 7.4.254.

Original comment by coryom...@gmail.com on 24 Apr 2014 at 9:46

@GoogleCodeExporter
Copy link
Author

Original comment by chrisbr...@googlemail.com on 2 Oct 2014 at 7:55

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant