Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On GNOME, modal dialog "file has changed" does not receive focus when opened #172

Closed
GoogleCodeExporter opened this issue Aug 18, 2015 · 5 comments
Closed

On GNOME, modal dialog "file has changed" does not receive focus when opened #172

GoogleCodeExporter opened this issue Aug 18, 2015 · 5 comments
Labels
auto-migrated defect Priority-Medium

Comments

@GoogleCodeExporter
Copy link 

To reproduce on Ubuntu GNOME 13.04 (trunk):

1. Open a file in GVIM.
2. Edit the file in another program.
3. Switch back to GVIM using one of
    * Alt-Tab switcher
    * Clicking on GVIM's title bar (not the client area)
    * The "Activities" switcher
    A modal dialog pops up saying 'W11: Warning: File "test" has changed since editing started'.

Expected: The modal dialog is focused, so that I can immediately dismiss it by 
pressing Enter or reload the file by pressing L.

Actual: The modal dialog is not focused. Keyboard input appears to be ignored.

Workaround: Switch away from GVIM and then back. (For instance, Alt+Tab twice.) 
The dialog receives focus. (You could also click using your mouse if you have 
time for such things.)

Original issue reported on code.google.com by lastor...@gmail.com on 12 Oct 2013 at 12:56
@hamishcunningham
Copy link

I also see this on Ubuntu 22.04...
(Vim 8.2, GTK 3.)
Tnx! H

@CS-cwhite
Copy link
Contributor

CS-cwhite commented Nov 19, 2024 •
edited
Loading

I also experience this.

  • Ubuntu 22.04.5 LTS amd64
  • GNOME 42.9
  • VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Oct 16 2024 17:27:14)
    • vim-gtk3==2:8.2.3995-1ubuntu2.20

Based on this SO answer, I think the answer might be to change

vim/src/gui_gtk.c

Line 1506 in 9a65a8c

GTK_DIALOG_DESTROY_WITH_PARENT,
like this:

-				     GTK_DIALOG_DESTROY_WITH_PARENT,
+				     GTK_DIALOG_MODAL,

However, I haven't tried it myself yet.

Edit No, it turns out that as of 9a65a8c, the fix is not that. Instead, I added

    gtk_window_set_type_hint(GTK_WINDOW(dialog), GDK_WINDOW_TYPE_HINT_POPUP_MENU);

after the create_message_dialog() call in gui_mch_dialog().

@chrisbra
Copy link
Member

can you please create a proper PR for your change then?

@CS-cwhite CS-cwhite mentioned this issue Nov 21, 2024
Closed
RestorerZ added a commit to RestorerZ/fork_vim-orig that referenced this issue Nov 24, 2024
@RestorerZ
consistency between chapter one and chapter two of the tutorial
Loading
Loading status checks…
676f6a0 
CI: Bump codecov/codecov-action from 4 to 5

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4...v5)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

closes: vim#16079

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0870: too many strlen() calls in eval.c

Problem:  too many strlen() calls in eval.c
Solution: Refactor eval.c to remove calls to STRLEN()
          (John Marriott)

closes: vim#16066

Signed-off-by: John Marriott <basilisk@internode.on.net>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0871: getcellpixels() can be further improved

Problem:  getcellpixels() can be further improved
Solution: Fix floating point exception, implement getcellpixels() in the
          UI (mikoto2000)

closes: vim#16059

Signed-off-by: mikoto2000 <mikoto2000@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0872: No test for W23 message

Problem:  No test for W23 message
Solution: Check for W23 message when accessing the clipboard fails
          (after v9.1.0868)

closes: vim#16076

Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0873: filetype: Vivado files are not recognized

Problem:  filetype: Vivado files are not recognized
Solution: detect '*.mss' files as 'mss' filetype
          (Wu, Zhenyu)

references:
https://docs.amd.com/r/2020.2-English/ug1400-vitis-embedded/Microprocessor-Software-Specification-MSS

closes: vim#15907

Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu>
Signed-off-by: Christian Brabandt <cb@256bit.org>

CI: join codecov array flags, instead of accessing it directly

closes: vim#16082

Signed-off-by: rhysd <lin90162@yahoo.co.jp>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0874: filetype: karel files are not detected

Problem:  filetype: karel files are not detected
Solution: detect '*.kl' files as karel filetype,
          include syntax and filetype plugin
          (Kirill Morozov)

closes: vim#16075

Co-authored-by: KnoP-01 <knosowski@graeffrobotics.de>
Signed-off-by: Kirill Morozov <kirill@robotix.pro>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0875: filetype: hyprlang detection can be improved

Problem:  filetype: hyprlang detection can be improved
Solution: detect '/hypr/*.conf' files as hyprlang filetype,
          include basic syntax highlighting (Luca Saccarola)

fixes: vim#15875
closes: vim#16064

Signed-off-by: Luca Saccarola <github.e41mv@aleeas.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0876: filetype: openCL files are not recognized

Problem:  filetype: openCL files are not recognized
Solution: detect '*.cl' files as opencl or lisp filetype,
          include a opencl syntax and filetype plugin (Wu, Zhenyu)

closes: vim#15825

Signed-off-by: Wu, Zhenyu <wuzhenyu@ustc.edu>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0877: tests: missing test for termdebug + decimal signs

Problem:  tests: missing test for termdebug + decimal signs
Solution: Add a termdebug test (Ubaldo Tiberi)

closes: vim#16081

Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@volvo.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0878: termdebug: cannot enable DEBUG mode

Problem:  termdebug: cannot enable DEBUG mode
Solution: Allow to specify DEBUG mode (Ubaldo Tiberi)

closes: vim#16080

Signed-off-by: Ubaldo Tiberi <ubaldo.tiberi@volvo.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(compiler): fix escaping of arguments passed to :CompilerSet

See newly added help entry referring to option-backslash

closes: vim#16084

Signed-off-by: Konfekt <Konfekt@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

Add clang-format config file

This is used in preparation to enable automatic code-formatting in the
following commits.  For now let's just add a clang-format config file,
formatting of source files will follow.

related: vim#16019

Signed-off-by: Luca Saccarola <github.e41mv@aleeas.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0879: source is not consistently formatted

Problem:  source is not consistently formatted
Solution: reformat sign.c and sound.c
          (Luca Saccarola)

closes: vim#16019

Signed-off-by: Luca Saccarola <github.e41mv@aleeas.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

git: ignore re-formatting commit v9.1.0879 for blame

Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(doc): add helptag for :HelpToc command

Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0880: filetype: C3 files are not recognized

Problem:  filetype: C3 files are not recognized
Solution: detect '*.c3*' files as c3 filetype (Turiiya)

closes: vim#16087

Signed-off-by: Turiiya <34311583+ttytm@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(misc): add Italian LICENSE and (top-level) README file

related: vim#16061

Signed-off-by: Antonio Giovanni Colombo <azc100@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(apache): Update syntax keyword definition

closes: vim#16105

Signed-off-by: nisbet-hubbard <87453615+nisbet-hubbard@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(netrw): update netrw's decompress logic

Detect a few more default archive types, correctly handle file
extensions with digits in it.

fixes: vim#16099
closes: vim#16104

Signed-off-by: Konfekt <Konfekt@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0881: GUI: message dialog may not get focus

Problem:  GUI: message dialog may not get focus
Solution: add window manager hint to give focus to the dialog
          (Chris White)

Tell the window manager that message dialogs should be given focus when
the user switches from another application back to Vim.  This can
happen, e.g., when the user has a file open in Vim and then edits it
in another program.

fixes: vim#172
closes: vim#16100

Signed-off-by: Chris White <christopher.white@crowdstrike.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>

patch 9.1.0882: too many strlen() calls in insexpand.c

Problem:  too many strlen() calls in insexpand.c
Solution: Refactor insexpand.c and reduce number of calls to STRLEN(),
          fix a warning get_next_filename_completion(), add new function
          ins_compl_leader_len() (John Marriott)

closes: vim#16095

Signed-off-by: John Marriott <basilisk@internode.on.net>
Signed-off-by: Christian Brabandt <cb@256bit.org>

runtime(netrw): Fixing powershell execution issues on Windows

closes: vim#16094

Signed-off-by: GuyBrush <miguel.barro@live.com>

runtime(doc): Expand docs on :! vs. :term

fixes: vim#16071
closes: vim#16089

Signed-off-by: matveyt <matthewtarasov@yandex.ru>
Signed-off-by: Christian Brabandt <cb@256bit.org>

rename the files of the chapter one to tutor1

The numbering of lessons in the files of chapter one begins with 1

the files of chapter one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated defect Priority-Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gui_gtk: Open message dialogs should be focused when main window activates CS-cwhite/vim
4 participants
@chrisbra @hamishcunningham @GoogleCodeExporter @CS-cwhite