My favorites | Sign in
v8
Project Home Downloads Wiki Issues Source Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 549: Make V8 call DebugMessageDispatchHandler with Locker locked
4 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  peter.ry...@gmail.com
Closed:  Jul 2
Cc:  sgjesse@chromium.org


Sign in to add a comment
 
Project Member Reported by peter.ry...@gmail.com, Dec 15, 2009
Context:
V8 is not running at the moment or in the middle of calling long-working 
C++ function. In any case thread does not have a v8 lock (hasn't locked or 
has temporarily unlocked). Meanwhile a new debug command has arrived and 
embedder-provided DebugMessageDispatchHandler callback is being called.

Feature:
V8 should make sure that the thread calling DebugMessageDispatchHandler has 
v8::Locker so that embedder could simply call V8 back without dealing with 
synchronization.
This involves V8 making sure that v8 lock MAY be acquired without being 
blocked. That's why DebugMessageDispatchHandler cannot simply create 
v8::Locker itself.

This way embedder may use v8::Locker solely, without a need for platform-
dependent mutexes and semaphores.
Dec 15, 2009
Project Member #1 peter.ry...@gmail.com
A very very rough implementation may be in http://codereview.chromium.org/503022
Labels: -Type-Bug Type-FeatureRequest
Dec 16, 2009
Project Member #2 peter.ry...@gmail.com
A much better alternative implementation is in http://codereview.chromium.org/505025

It takes one additional thread, but requires minimum changes in V8.
Jul 2, 2014
Project Member #3 yangguo@chromium.org
This has been fixed. Recently, DebugMessageDispatchHandler has been removed altogether.
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting