My favorites | Sign in
v8
Project Home Downloads Wiki Issues Source Code Search
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 498: ScanNumber and zeros
7 people starred this issue and may be notified of changes. Back to list
Status:  Assigned
Owner:  ma...@chromium.org


Sign in to add a comment
 
Reported by Serge.Sitnikov@gmail.com, Nov 7, 2009
ScanNumber (scanner.cc) always eat all zeroes of decimal integer parts (000, 
008, 008.1), they are all consumed in octal check loop. It is not a big deal 
to violate spec in that particular case, but the comment at the end of the 
function makes opposite statement and refers the spec. Comment should be 
corrected, I think.
Nov 7, 2009
#1 Serge.Sitnikov@gmail.com
By the way, check for immediately following decimal digit at the end of the function 
may be removed too. It is useless.
Nov 14, 2010
#2 lrn%chro...@gtempaccount.com
(No comment was entered for this change.)
Owner: LasseReichsteinHolstNielsen
Jul 2, 2014
Project Member #3 yangguo@chromium.org
I doubt that this is still an issue. Marja, could you confirm?
Status: Assigned
Owner: ma...@chromium.org
Jul 2, 2014
Project Member #4 ma...@chromium.org
What does "eat all zeroes of decimal integer parts" mean?

Iirc, 000 will be octal, 008 will be decimal (because 8 is not a valid octal digit), 008.1 too, and 007.1 would be an error.
Sign in to add a comment

Powered by Google Project Hosting