My favorites | Sign in
Project Home Downloads Wiki Issues Source Code Search
New issue   Search
  Advanced search   Search tips   Subscriptions
Issue 2295: ES5 readonly-ness problem in Crankshaft
3 people starred this issue and may be notified of changes. Back to list
Project Member Reported by, Aug 17, 2012
I started to investigate a problem with the ES5 readonly-ness in optimized code. The following will reproduce the problem.

$ ./tools/ -j12 --no-presubmit --arch=ia32 --mode=release --report --special-command="@ --max-opt-count=1000" mjsunit/readonly

I narrowed it down HGraphBuilder::BuildStoreNamedField where we don't check for readonly-ness induced by a JavaScript accessor that only has a getter but no setter. The band-aid fix would be to just check for that situation here. But after discussing this with Andreas, it has become clear to us that we need to keep the property attributes in sync when defining accessors. Whenever a JavaScript accessor doesn't have a setter, the internal readonly attribute should be set implicitly. That's the clean fix that would simplify all sites that check for readonly-ness.
Sign in to add a comment

Powered by Google Project Hosting