Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images as links is broken when both addresses are protected #169

Closed
GoogleCodeExporter opened this issue Apr 18, 2015 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?

This works: [[""http://txt2tags.org/img/t2tpowered"".png] http://google.com].

This does not: [[""http://txt2tags.org/img/t2tpowered"".png] 
""http://google.com""].


What is the expected output? What do you see instead?

Would expect both lines to output the same code :
<A HREF="http://google.com"><IMG ALIGN="middle" 
SRC="http://txt2tags.org/img/t2tpowered.png" BORDER="0" ALT=""></A>.

What you actually get in the second case:
 <A HREF="http://txt2tags.org/img/t2tpowered"><IMG ALIGN="middle" SRC="http://google.com.png" BORDER="0" ALT=""></A>.

(note that the HREF and the SRC addresses are the wrong way round)

What version of the product are you using? On what operating system?

Online demo (vanilla), latest stable release (and original found in the 
RedNotebook version https://bugs.launchpad.net/rednotebook/+bug/1051547)

Please provide any additional information below.

I believe it it because txt2tags replaces the protected links with a place 
holder - vvvRAWvvv and stores the links in the rawbank. The conversion then 
happens and the link locations are rearranged before the links are pasted back 
into the body (this time in the wrong locations).

The only way I can see to fix this would be to change the rawbank from a list 
to a dictionary and put an id in each vvvRAWvvv placeholder. This would be a 
rather large change and whilst would improve robustness of the system, it may 
be considered extra bloat.


Original issue reported on code.google.com by runninga...@gmail.com on 16 Sep 2012 at 12:42

@GoogleCodeExporter
Copy link
Author

PS: the reason it does not work has nothing to do with the missing ] at the end 
of the second line. That was just a copy and paste error!

Original comment by runninga...@gmail.com on 16 Sep 2012 at 12:43

@GoogleCodeExporter
Copy link
Author

Now that you mention the rawbank: This might actually be fixed in txt2tags 
trunk since the escaping has been overhauled recently. Is it fixed there 
already?

Original comment by jendriks...@gmail.com on 16 Sep 2012 at 1:09

@GoogleCodeExporter
Copy link
Author

Just checked and you are right, the issue is fixed in the latest SVN version. 
Just need to wait till it is included into the latest RNB :)

Thanks

Original comment by runninga...@gmail.com on 16 Sep 2012 at 2:31

@GoogleCodeExporter
Copy link
Author

Original comment by jendriks...@gmail.com on 16 Sep 2012 at 3:15

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant