Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring txt2tags GUI #162

Open
GoogleCodeExporter opened this issue Apr 18, 2015 · 4 comments
Open

Consider refactoring txt2tags GUI #162

GoogleCodeExporter opened this issue Apr 18, 2015 · 4 comments
Labels
auto-migrated Priority-Medium Type-Enhancement

Comments

@GoogleCodeExporter
Copy link 

Currently the Gui works this way:

1. txt2tagslite imports lib/gui_tk.py
2. txt2tagslite creates a new instance of the Gui and runs it
3. the Gui current code needs lots of txt2tags globals to work, so all txt2tags 
globals are imported into the module namespace (UGLY)

The correct way of handling the Gui would be:

1. Create a new txt2tags-gui executable Python script
2. This script contains the Tk code and imports txt2tags as a module
3. As a module, txt2tags handles the convertion (no need for globals mess)

Original issue reported on code.google.com by aureliojargas@gmail.com on 28 Jul 2012 at 12:34
@GoogleCodeExporter
Copy link
Author 

For me the current hackish/ugly way is ok for txt2tags 2.7 release.

Original comment by fgalla...@gmail.com on 29 Jul 2012 at 2:21

@GoogleCodeExporter
Copy link
Author 

I also vote for cleaning this up.

Original comment by jendriks...@gmail.com on 29 Jul 2012 at 11:07

@GoogleCodeExporter
Copy link
Author 

Agree with Florent that this change must be made after v2.7.

Original comment by aureliojargas@gmail.com on 22 Mar 2013 at 1:13

@aureliojargas
Copy link
Member

FYI, the GUI was removed in the v3 branch, more specifically in the txt2tags 3.2 version: https://github.com/txt2tags/txt2tags/blob/v3/CHANGELOG.md#version-32-2019-10-30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aureliojargas @GoogleCodeExporter