Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n back to the core #161

Open
GoogleCodeExporter opened this issue Apr 18, 2015 · 7 comments
Open

i18n back to the core #161

GoogleCodeExporter opened this issue Apr 18, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Please revert r984.

Original issue reported on code.google.com by aureliojargas@gmail.com on 27 Jul 2012 at 7:00

@GoogleCodeExporter
Copy link
Author

hum hum, we are trying to do txt2tagslite modular with the targets directory. 
I18n is needed by the targets (at least for NAME) and the __init__.py file IS 
the core of the system. It deals with conf 'globals', line command options and 
targets import, he is always needed and make txt2tagslite modular.
We could duplicate the code in txt2tagslite,but it's ugly, and we should never 
remove it from __init__.py.
If txt2tags is generated from txt2tagslite, we can add i18n like all the others 
things we need...

Original comment by fgalla...@gmail.com on 27 Jul 2012 at 8:21

@GoogleCodeExporter
Copy link
Author

But i18n is also needed by the main script and by the lib/gui_tk.py files, it's 
not specific to targets.

What about a lib/i18n.py file? It seems like a better place so everybody else 
can import it.


Original comment by aureliojargas@gmail.com on 30 Jul 2012 at 3:09

@GoogleCodeExporter
Copy link
Author

For sure Aurélio, lib/i18n.py is a best place (when you said 'back to the 
core', I understood 'back in the main file', and this was not good for me).

Original comment by fgalla...@gmail.com on 1 Aug 2012 at 12:44

@GoogleCodeExporter
Copy link
Author

You got it right! It was referring to the main file, but after your reply I 
realized that that was not a good idea :)

Oh, and BTW, last year, after 33 years writing it wrong, I discovered that my 
name does NOT have an accent. Believe it or not.

--
Aurelio :)

Original comment by aureliojargas@gmail.com on 2 Aug 2012 at 5:39

@GoogleCodeExporter
Copy link
Author

Ok, not *exactly* 33 years because I was not *that* smart as a baby or child :)

Original comment by aureliojargas@gmail.com on 2 Aug 2012 at 5:40

@GoogleCodeExporter
Copy link
Author

So you were ASCII 7-bits compatible since the beginning !

Original comment by fgalla...@gmail.com on 2 Aug 2012 at 8:56

@GoogleCodeExporter
Copy link
Author

Yes! If I knew it before, it would have saved me lots of encoding troubles :)

Original comment by aureliojargas@gmail.com on 2 Aug 2012 at 9:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant