Issue 22 - tweener - trunk/as2 Syntax Fixes & Optimizations

Issue 22:	trunk/as2 Syntax Fixes & Optimizations
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	zisforzeh
Closed:	Dec 2007
Type-Defect
Priority-Medium

Reported by sekati, Nov 15, 2007

Using FDT3 with moderate warning/error checking there are a few unused variables, syntax 
warnings and such Ill try to document cleanly for you (non-critical but nice to cleanup):

AuxFunctions.as
-------------
- Line 64: for (var pName:String in p_object) totalProperties ++; // pName Local var never used: 
no fix.
- Line 82 fix: finalObject[prop] = currentObject[prop]; // was missing semicolen

Equations.as
-------------
- Line 36: trace ("Equations is a static class and should not be instantiated."); // was missing 
semicolen

Tweener.as
-------------
- Line 64: trace ("Tweener is an static class and should not be instantiated."); // was missing 
semicolen
- Line 96: var i:Number, istr:Number; // local vars j:Number, jstr:String never used
- Line 186: //var cTime:Number; // Local var cTime never used
- Line 271: var i:Number; //  `j:Number` local var never used 
- Line: 981: fmc.onEnterFrame = function():Void { // missing return type

Comment 1 by zisforzeh, Nov 15, 2007

Very nice. Thanks for this! I'll handle it.

Status: Accepted
Owner: zisforzeh

Comment 2 by sekati, Dec 11, 2007

I noticed a few of these fixes were added to 1.31.68 but some were missed:
64 - trace missing semicolen
96 - jstr:String never used
186 - var cTime:Number never used
270 - j:Number; never used
917 - fmc.onEnterFrame = function() - missing return type

Hope my repeating is not annoying - I just cant stand warning/error icons in my eclipse/fdt projects ;-)

Comment 3 by zisforzeh, Dec 11, 2007

1.31.68 was just a quick error fix version. I'm working on another version that's not
on the svn and that's why having those warning fixed wasn't a high priority.

I'll update the current version to fix that then.

Comment 4 by sekati, Dec 11, 2007

I totally understand - makes sense now.

Comment 5 by zisforzeh, Dec 12, 2007

Changed and commited (1.31.69).

Let me know if you run into anything else.

Thanks.

Status: Fixed