Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Implement Queues #7

Closed
GoogleCodeExporter opened this issue Apr 10, 2015 · 8 comments
Closed

Implement Queues #7

GoogleCodeExporter opened this issue Apr 10, 2015 · 8 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

Tulip has Lock, EventWaiter, Condition, and Semaphore. I propose it should have 
Queue, JoinableQueue, LifoQueue, and PriorityQueue. I offer to implement them. 
I'm starting here:

http://code.google.com/r/jesse-tulip/source/browse/tulip/queues.py

http://code.google.com/r/jesse-tulip/source/browse/tests/queues_test.py

I'll submit a patch in a couple days or weeks when they're solid.

Original issue reported on code.google.com by jesse@emptysquare.net on 17 Mar 2013 at 10:19
@GoogleCodeExporter
Copy link
Author 

Here's an initial implementation and a reasonably thorough test suite, ported 
from my package, Toro (https://github.com/ajdavis/toro).

Original comment by jesse@emptysquare.net on 18 Mar 2013 at 6:00

Attachments:

@GoogleCodeExporter
Copy link
Author 

Thanks! I will review this as soon as my queue is empty.

(PS. Would you like to contribute regularly? If you sign the PSF contributor 
agreement, you can.  http://www.python.org/psf/contrib/contrib-form/ )

Original comment by gvanrossum@gmail.com on 18 Mar 2013 at 6:06

@GoogleCodeExporter
Copy link
Author 

A better patch -- compared to the previous one, this patch fixes the order that 
getters and putters are run (it's now the same as with Gevent's Queue), 
simplifies the code a little, and removes some Tornadoisms from the docstrings.

Original comment by jesse@emptysquare.net on 18 Mar 2013 at 6:10

Attachments:

@GoogleCodeExporter
Copy link
Author 

(PS. I'd be honored to contribute regularly; I've now signed the contributor 
agreement.)

Original comment by jesse@emptysquare.net on 18 Mar 2013 at 6:17

@GoogleCodeExporter
Copy link
Author 

Ok, so instead of attaching patches to the issue, would you mind uploading it 
to codereview.appspot.com and pasting the issue link here?  Use the upload.py 
script -- you can download it by clicking on "Create Issue".

Original comment by gvanrossum@gmail.com on 18 Mar 2013 at 6:21

@GoogleCodeExporter
Copy link
Author 

This is now happening in https://codereview.appspot.com/7751044/ .  Remind me 
to close this when that lands.

Original comment by gvanrossum@gmail.com on 20 Mar 2013 at 12:55

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by gvanrossum@gmail.com on 20 Mar 2013 at 1:00

@GoogleCodeExporter
Copy link
Author 

This issue was closed by revision f83dba559f89.

Original comment by jesse@emptysquare.net on 21 Mar 2013 at 12:59

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter