Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Fix the proactor write pipe transport #121

Closed
GoogleCodeExporter opened this issue Apr 10, 2015 · 3 comments
Closed

Fix the proactor write pipe transport #121

GoogleCodeExporter opened this issue Apr 10, 2015 · 3 comments
Labels
auto-migrated Priority-Medium Type-Defect

Comments

@GoogleCodeExporter
Copy link 

On Windows, test_events.test_subprocess_kill() fails because 
WriteSubprocessPipeProto has no eof_received() method. I suppose that the 
failure is related to my fix in overlapped.c (changeset 3003f31eefe1).

Original issue reported on code.google.com by victor.s...@gmail.com on 31 Jan 2014 at 8:08

Attachments:
@GoogleCodeExporter
Copy link
Author 

I commited the patch on Python to unblock Windows buildbots which were all read:
http://bugs.python.org/issue20455
http://hg.python.org/cpython/rev/4c496d53b1e1

Original comment by victor.s...@gmail.com on 31 Jan 2014 at 1:20

@GoogleCodeExporter
Copy link
Author 

I synced the Tulip repo since the tests were failing there (on Windows) too. 
But I didn't merge it into the subprocess_stream branch -- the merge was a 
little funky and running the tests gave a new error (Skipping 
'test_proactor_events': name '_ProactorWritePipeTransport' is not defined).

Original comment by gvanrossum@gmail.com on 31 Jan 2014 at 9:28

@GoogleCodeExporter
Copy link
Author 

>  the merge was a little funky and running the tests gave a new error 
(Skipping 'test_proactor_events': name '_ProactorWritePipeTransport' is not 
defined).

Ah? I did the merge and it was quite trivial. I just pushed it.

Original comment by victor.s...@gmail.com on 31 Jan 2014 at 10:23

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter