The message pane (#messagepane) should be moved out of .txp-header #237
Comments
ghost
added
|
From p...@designhive.com on July 25, 2012 03:26:20 This is being changed at v4.6, when we will indeed be going to HTML5 markup. The message pane will be in the role='main' section/div (whichever tag we settle on) after the initial h1.txp-heading tag. You can then position it wherever you like via CSS of course. |
|
From ph.witte...@gmail.com on July 25, 2012 04:49:58 Assuming your [role="main"] block corresponds to the current .txp-body block, that sounds OK. One might argue that it could make more sense to have that element as last child of the [role="main"] block, but that's more on the nitpicking level. |
|
From stefdawson on August 20, 2012 08:38:27 Labels: Milestone-4.6 |
|
@philwareham Is this done in either master or admin-layout-update? If so, can it be closed? |
|
Nope, it is not yet done on either branch. |
|
Will be done soon - it's a 4.6 blocker for me. |
|
Done. Can be closed when we merge admin-layout-update branch into master. |
|
@phiw13 Also: maybe the HTML of these can probably be improved, since the |
|
@philwareham |
From ph.witte...@gmail.com on July 25, 2012 09:01:48
The #messagepane is in no way related to the semantics of 'header' (masthead) of the Textpattern CMS UI. Assuming we move, txp 4.6 ?, towards html5 markup, .txp-head would become a
<header>instead of a<div>in the present markup. #messagepane would then be more out of place (according to the semantics of the<header>element).messagepane should become either
[1] a direct child of body
[2] a first- or last-child of .txp-body
(I prefer option the second option; after all that element is directly related to actions performed on elements contained inside .txp-body)
Having #messagepane as a child of .txp-head does impose some (serious) limits on what can be done with the 'header'. For example in my Sandspaces theme (*) I position the 'header' as a side-column using position: absolute. If I were to use .txp-header for this, #messagepane would forever be trapped inside that block. At present I work around this by adding a div (#masthead in my case), child of .txp-header and position that. I'd like to get rid of that additional div.
I think the Hive theme would face similar constrains.
An additional benefit: a theme author doesn't need to add #messagepane inside his or her themename.php file…
(*) http://forum.textpattern.com/viewtopic.php?id=38139 ---
(this is certainly not urgent for Txp 4.5, more like something for Textpattern.next
Original issue: http://code.google.com/p/textpattern/issues/detail?id=233
The text was updated successfully, but these errors were encountered: