Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't article_posted callback event's $rs argument contain populated ID too? #233

Closed
ghost opened this issue Oct 4, 2014 · 1 comment

Comments

@ghost
Copy link

ghost commented Oct 4, 2014

From jukka.svahn@rahinaa.biz on July 22, 2012 20:30:24

Callback functions hooking to the "article_posted" and "article_saved" are fed with the raw POST data. Which itself is fine. Due to this, on the "article_posted" event callback functions don't get the article's ID that was saved. Safe to assume, most that hook to these will need it.

While the ID is available with infamously named global variable, putting it to the actual data map could be beneficial. At least it simplified code of callback's members, and if I'm not mistaken, the bigger picture on the pipeline is to get rid of these infamously named global variables as "$ID", "$DB", "$vars" and such.

And well, the change wouldn't be more than about 10 characters counting couple spaces.

Please see attached patch. The patch does the mentioned and adds the posted article's ID to the $rs array.

Attachment: txp_article.php.r3995.patch

Original issue: http://code.google.com/p/textpattern/issues/detail?id=229

@ghost ghost added the imported label Oct 4, 2014
@ghost
Copy link
Author

ghost commented Oct 4, 2014

From r.wetzlmayr on July 23, 2012 00:20:59

This issue was closed by revision r3996 .

Status: Fixed

@ghost ghost closed this as completed Oct 4, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants