Article pane, failed inserts, given incorrect ID #163
Labels
Comments
ghost
added
|
From jukka.svahn@rahinaa.biz on April 05, 2012 10:14:29 Attached a patch. The patch checks used safe_insert() and safe_update() instances' statuses, and returns human-friendly message, branded as E_ERROR, on error. Simple few line addition. Attachment: txp_article.php.r3709.patch |
|
From r.wetzlmayr on April 18, 2012 01:15:26 Fixed in r3741 . Status: Fixed |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From jukka.svahn@rahinaa.biz on April 05, 2012 19:02:45
On articles pane the saving to DB should carefully validated, in case of an error. In other words safe_insert() should be checked and made sure it doesn't return FALSE.
If it does return FALSE, the article wasn't saved and mysql_insert_id() will give an incorrect ID.
When this happens, user's following saves will either commit saves to incorrect article, form goes to oblivion, or the form is ignored gracefully.
Original issue: http://code.google.com/p/textpattern/issues/detail?id=159
The text was updated successfully, but these errors were encountered: