Export to GitHub

tenfourfox - issue #225

Default gfx.color_management.profilev4 to true for better colour fidelity


Posted on May 19, 2013 by Massive Rhino

Uplift from http://tenfourfox.tenderapp.com/discussions/problems/394-color-profiling-not-working

We might need to instrument the code in https://bugzilla.mozilla.org/show_bug.cgi?id=514932 or roll it back.

Comment #1

Posted on May 19, 2013 by Massive Rhino

In gfx/thebes/gfxPlatform.cpp, we try sRGB first (if gfx.color_management.force_srgb is true), then try to load any specified profile, then try to load the platform profile. If the platform profile is bogus, assume sRGB. We should be able to see by enabling DEBUG_tor in gfxPlatformMac::GetPlatformCMSOutputProfile() whether it actually can load it.

Comment #2

Posted on May 19, 2013 by Massive Rhino

We should also make sure that the gamma seen by qcms is, indeed, 1.8.

Comment #3

Posted on May 19, 2013 by Massive Rhino

Image from reporter (NSFW): http://photos.modelmayhem.com/photos/090416/11/49e77a949088d.jpg

Comment #4

Posted on May 19, 2013 by Massive Rhino

Adding some instrumentation, the Huey profile on the G5 appears to load:

CMGetProfileByAVID NCMGetProfileLocation NCMGetProfileLocation ok ICM profile read from /home/spectre/Library/ColorSync/Profiles/huey Unnamed Mo fileLoc successfully

The Huey profile doesn't have a gamma value; it has direct colour sampling. The Generic RGB Profile does have a gamma of 1.8.

Comment #5

Posted on May 19, 2013 by Massive Rhino

Setting gfx.color_management.enablev4 to true fixes the problem (Preview and TenFourFox are identical for the huey profile).

Comment #6

Posted on May 19, 2013 by Massive Rhino

With this enabled for Generic RGB, the image is better, though does not quite match Preview.

Comment #7

Posted on May 19, 2013 by Massive Rhino

Adam, when you look at this bug, please report in whether toggling that setting has an effect for you.

Comment #8

Posted on May 19, 2013 by Massive Rhino

There is a bug with enabling V4 profiles (M722831). This bug did not land on ESR, so ESR will need that also:

https://hg.mozilla.org/releases/mozilla-beta/rev/4cee1607a72e

Comment #9

Posted on May 19, 2013 by Massive Rhino

(No comment was entered for this change.)

Comment #10

Posted on May 19, 2013 by Massive Rhino

Also, https://bugzilla.mozilla.org/show_bug.cgi?id=739785

Comment #11

Posted on May 20, 2013 by Massive Rhino

Pref toggled in 22.

Comment #12

Posted on May 21, 2013 by Happy Bear

The test image from Tender is displayed correctly in TFF 21 if gfx.color_management.enablev4 is set to true. I see you already discovered it yourself, this is just to confirm it also works on 10.5. Also color.org/version4html.xalter renders with four correct quadrants.

Comment #13

Posted on May 21, 2013 by Massive Rhino

Excellent. Scheduled for 17.0.7/22 then.

Comment #14

Posted on Jun 20, 2013 by Massive Rhino

Both changes checked into 17.0.7

Comment #15

Posted on Jun 23, 2013 by Massive Rhino

Checked into 22.0

Status: Verified

Labels:
Type-Defect Priority-Medium Milestone-NextStable